[flake8-type-checking] Disable TC006 & TC007 in stub files#15179
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Dec 29, 2024
Merged
[flake8-type-checking] Disable TC006 & TC007 in stub files#15179charliermarsh merged 1 commit intoastral-sh:mainfrom
flake8-type-checking] Disable TC006 & TC007 in stub files#15179charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Daverball
force-pushed
the
bugfix/tc-rules-in-stubs
branch
from
dedfdcf to
2b2f391
Compare
Daverball
force-pushed
the
bugfix/tc-rules-in-stubs
branch
from
2b2f391 to
01cd7fb
Compare
Contributor
|
Contributor
Author
|
Addressed the TC008 part in #15180 |
dcreager
added a commit
that referenced
this pull request
Dec 30, 2024
* main: Add all PEP-585 names to UP006 rule (#5454) [`flake8-simplify`] More precise inference for dictionaries (`SIM300`) (#15164) `@no_type_check` support (#15122) Visit PEP 764 inline `TypedDict`s' keys as non-type-expressions (#15073) [red-knot] Add diagnostic for invalid unpacking (#15086) [`flake8-use-pathlib`] Catch redundant joins in `PTH201` and avoid syntax errors (#15177) Update Rust crate glob to v0.3.2 (#15185) Update astral-sh/setup-uv action to v5 (#15193) Update dependency mdformat-mkdocs to v4.1.1 (#15192) Update Rust crate serde_with to v3.12.0 (#15191) Update NPM Development dependencies (#15190) Update pre-commit hook rhysd/actionlint to v1.7.5 (#15189) Update Rust crate syn to v2.0.93 (#15188) Update Rust crate serde to v1.0.217 (#15187) Update Rust crate quote to v1.0.38 (#15186) Update Rust crate compact_str to v0.8.1 (#15184) [`flake8-type-checking`] Disable TC006 & TC007 in stub files (#15179) Test explicit shadowing involving `def`s (#15174) Fix typo in `NameImport.qualified_name` docstring (#15170) [airflow]: extend names moved from core to provider (AIR303) (#15159)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15176
Summary
Neither of these rules make any sense in stub files. Technically TC007 should already not have triggered, due to the typing only context of the binding, but it's better to be explicit.
Keeping TC008 enabled on the other hand makes sense to me, although we could probably be more aggressive with unquoting in a typing runtime context.
Test Plan
cargo nextest run