Remove formatter incompatibility warning for ISC001#15123
Merged
MichaReiser merged 1 commit intoruff-0.9from Jan 3, 2025
Merged
Remove formatter incompatibility warning for ISC001#15123MichaReiser merged 1 commit intoruff-0.9from
MichaReiser merged 1 commit intoruff-0.9from
Conversation
MichaReiser
force-pushed
the
micha/remove-isc001-warn
branch
from
f9e0ebd to
e777a2f
Compare
Contributor
|
charliermarsh
approved these changes
Dec 23, 2024
MichaReiser
force-pushed
the
micha/ruff-2025
branch
from
ec04f00 to
62633a3
Compare
MichaReiser
force-pushed
the
micha/remove-isc001-warn
branch
from
e777a2f to
aebcf27
Compare
MichaReiser
added a commit
that referenced
this pull request
Jan 8, 2025
MichaReiser
added a commit
that referenced
this pull request
Jan 8, 2025
MichaReiser
added a commit
that referenced
this pull request
Jan 9, 2025
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/cookie
that referenced
this pull request
Mar 6, 2025
Starting with ruff 0.9.0, rules ISC001 and ISC002 are compatible with the ruff formatter: * https://astral.sh/blog/ruff-v0.9.0#fewer-single-line-implicitly-concatenated-strings * astral-sh/ruff#15123
henryiii
pushed a commit
to scientific-python/cookie
that referenced
this pull request
Mar 6, 2025
Starting with ruff 0.9.0, rules ISC001 and ISC002 are compatible with the ruff formatter: * https://astral.sh/blog/ruff-v0.9.0#fewer-single-line-implicitly-concatenated-strings * astral-sh/ruff#15123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the formatter incompatility warning from
ISC001because the formatter now:This PR adds a warning for
lint.flake8-implicit-str-concat.allow-multiline = falseifISC001is disabled.This is not a new incompatibility, it's just that we forgot to add it.
Test Plan
See CLI tests