Add tests demonstrating f-strings with debug expressions in replacements that contain escaped characters#14929
Merged
MichaReiser merged 1 commit intomainfrom Dec 12, 2024
Conversation
…nts that contain escaped characters
MichaReiser
commented
Dec 12, 2024
Comment on lines
-180
to
-181
| let options = PyFormatOptions::from_extension(input_path); | ||
| let formatted_code = format_file(&content, &options, input_path); |
Member
Author
There was a problem hiding this comment.
Ha, that took me a minute to figure out. We always formatted the code once with the default options even if there's an options file. We don't want that, so I moved it into the else branch`
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two test cases that were reported in #14766 and #14926
Test Plan
cargo test