Skip to content

[red-knot] split call-outcome enums to their own submodule#14898

Merged
carljm merged 1 commit intomainfrom
cjm/splitcall
Dec 10, 2024
Merged

[red-knot] split call-outcome enums to their own submodule#14898
carljm merged 1 commit intomainfrom
cjm/splitcall

Conversation

@carljm
Copy link
Copy Markdown
Contributor

@carljm carljm commented Dec 10, 2024

Summary

This is already several hundred lines of code, and it will get more complex with call-signature checking.

Test Plan

This is a pure code move; the moved code wasn't changed, just imports. Existing tests pass.

@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+4 -2 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

pandas-dev/pandas (+4 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pandas/io/formats/style.py:1147:13: RUF052 Local dummy variable `_original_columns` is accessed
- pandas/io/formats/style.py:145:1: E113 Unexpected indentation
- pandas/io/formats/style.py:145:45: W292 No newline at end of file
+ pandas/io/formats/style.py:3928:5: RUF052 Local dummy variable `_matplotlib` is accessed
+ pandas/io/formats/style.py:4112:89: E501 Line too long (91 > 88)
+ pandas/io/formats/style.py:4217:9: RUF052 Local dummy variable `_matplotlib` is accessed

Changes by rule (4 rules affected)

code total + violation - violation + fix - fix
RUF052 3 3 0 0 0
E501 1 1 0 0 0
E113 1 0 1 0 0
W292 1 0 1 0 0

@carljm carljm merged commit 03fb2e5 into main Dec 10, 2024
@carljm carljm deleted the cjm/splitcall branch December 10, 2024 20:03
dcreager added a commit that referenced this pull request Dec 10, 2024
* main:
  [red-knot] split call-outcome enums to their own submodule (#14898)
  [red-knot] Property tests: account non-fully-static types (#14897)
  ruff: add worktree support to build.rs (#14896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant