[red-knot] Property tests: account non-fully-static types#14897
Merged
[red-knot] Property tests: account non-fully-static types#14897
Conversation
sharkdp
requested review from
AlexWaygood,
MichaReiser and
carljm
as code owners
carljm
approved these changes
Dec 10, 2024
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Looks good, thank you!
I guess we could also add a non_fully_static_types_do_not_participate_in_equivalence test?
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I probably broke these tests myself in #14758. I don't know how that happened because I even added a new property test there, but maybe I ran the tests with a filter. Anyway, adding a
is_fully_staticpremise to these two tests seems like the right thing to do.There is another (actual) problem with
assignable_to_is_reflexivewhich we'll also need to address, I'll open a ticket.Test Plan