[pyupgrade] Remove unreachable code in UP015 implementation#14871
Merged
AlexWaygood merged 2 commits intoastral-sh:mainfrom Dec 9, 2024
Merged
[pyupgrade] Remove unreachable code in UP015 implementation#14871AlexWaygood merged 2 commits intoastral-sh:mainfrom
pyupgrade] Remove unreachable code in UP015 implementation#14871AlexWaygood merged 2 commits intoastral-sh:mainfrom
Conversation
Signed-off-by: harupy <[email protected]>
harupy
commented
Dec 9, 2024
Contributor
|
harupy
commented
Dec 9, 2024
crates/ruff_linter/src/rules/pyupgrade/rules/redundant_open_modes.rs
Outdated
Show resolved
Hide resolved
harupy
changed the title
UP015pyupgrade] Remove unreachable code in UP015
AlexWaygood
changed the title
pyupgrade] Remove unreachable code in UP015pyupgrade] Remove unreachable code in UP015 implementation
dcreager
added a commit
that referenced
this pull request
Dec 10, 2024
* main: [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887) Improve mdtests style (#14884) Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888) [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408) [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824) [red-knot] Improve type inference for except handlers (#14838) More typos found by codespell (#14880) [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879) [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832) Stop referring to early ruff versions (#14862) Fix a typo in `class.rs` (#14877) [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801) [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871) [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/ruff_linter/src/rules/pyupgrade/rules/redundant_open_modes.rshas unreachable code. This PR removes it.Test Plan
No behavior change. No test.