Stop referring to early ruff versions#14862
Merged
MichaReiser merged 3 commits intoastral-sh:mainfrom Dec 9, 2024
Merged
Conversation
docs/formatter.md
Outdated
| @@ -23,7 +21,7 @@ and instead exit with a non-zero status code upon detecting any unformatted file | |||
| For the full list of supported options, run `ruff format --help`. | |||
|
|
|||
| !!! note | |||
Contributor
Author
There was a problem hiding this comment.
Perhaps this shouldn't be a note any more, should it?
Member
There was a problem hiding this comment.
Yeah, I think we can remove the entire note here
docs/linter.md
Outdated
| @@ -20,7 +20,7 @@ $ ruff check path/to/code/ # Lint all files in `path/to/code` (and any subdir | |||
| For the full list of supported options, run `ruff check --help`. | |||
|
|
|||
| !!! note | |||
Contributor
Author
There was a problem hiding this comment.
I have just removed the notes.
MichaReiser
approved these changes
Dec 9, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks. This makes sense to me. I did a quick check and 0.1.3 is the version with the most downloads in the last 30 days (~90k) that is impacted by this documentation change. All other <=0.1.7 versions have fewer than 50k downloads in the last 30 days.
dhruvmanila
reviewed
Dec 9, 2024
Comment on lines
351
to
353
| # Ruff version. | ||
| rev: v0.1.4 | ||
| rev: v0.8.2 | ||
| hooks: |
Member
There was a problem hiding this comment.
We can add this file to
Lines 106 to 113 in 3d9ac53
Contributor
Author
There was a problem hiding this comment.
Added docs/tutorial.md.
Referring to old versions has become more distracting than useful.
DimitriPapadopoulos
force-pushed
the
v
branch
from
df0eba3 to
a2cd270
Compare
Contributor
|
dcreager
added a commit
that referenced
this pull request
Dec 10, 2024
* main: [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887) Improve mdtests style (#14884) Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888) [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408) [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824) [red-knot] Improve type inference for except handlers (#14838) More typos found by codespell (#14880) [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879) [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832) Stop referring to early ruff versions (#14862) Fix a typo in `class.rs` (#14877) [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801) [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871) [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Referring to old versions has become more distracting than useful.
Test Plan
—