[red-knot] Understanding type[Union[A, B]]#14858
Merged
AlexWaygood merged 6 commits intoastral-sh:mainfrom Dec 9, 2024
Merged
Conversation
InSyncWithFoo
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
Contributor
Author
|
The failing test boils down to this: import collections
MyObj1 = collections.namedtuple("MyObj1", ["a", "b"]) |
MichaReiser
previously requested changes
Dec 9, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
The tests are failing with a panic in an assertion. Would you mind taking a look at what's happening
AlexWaygood
approved these changes
Dec 9, 2024
Member
There was a problem hiding this comment.
Thanks. There were a couple of issues with your initial patch; I've pushed to your branch to fix them:
- You didn't handle single-element unions such as
type[Union[int]](the subscript slice inside theUnion[]is not anExpr::Tupleif there's only a single element). - You were failing to store the types of subexpressions for subscripts that are either invalid or not-yet-supported; that was causing panics in the corpus test. It can be surprisingly tricky to make sure that you infer the type of each subexpression exactly once; it took me longer than I expected to fix this!
- Going forward, we'd prefer to use parameter annotations in mdtests to test type expressions rather than return annotations, as they're more concise (#14839)
Contributor
|
Contributor
Author
|
@AlexWaygood Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14834.
Test Plan
Markdown tests.