[ruff] Do not simplify round() calls (RUF046)#14832
Merged
MichaReiser merged 5 commits intoastral-sh:mainfrom Dec 9, 2024
Merged
[ruff] Do not simplify round() calls (RUF046)#14832MichaReiser merged 5 commits intoastral-sh:mainfrom
ruff] Do not simplify round() calls (RUF046)#14832MichaReiser merged 5 commits intoastral-sh:mainfrom
Conversation
Contributor
|
MichaReiser
requested changes
Dec 8, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks for splitting the PR!
I think the rule is now over eager in removing int calls from rount
...ter/src/rules/ruff/snapshots/ruff_linter__rules__ruff__tests__preview__RUF046_RUF046.py.snap
Outdated
Show resolved
Hide resolved
Contributor
Author
|
For reference, here's the logic table for
|
InSyncWithFoo
force-pushed
the
RUF046-1
branch
from
7f59f86 to
1b87b71
Compare
Member
|
Nice table: From testing a few cases, it seems that But we should not create a diagnostic if |
MichaReiser
added
rule
MichaReiser
approved these changes
Dec 9, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Nice. This looks good now, except that we can also provide a safe fix if the number is an int, and ndigits is any integer.
Contributor
Author
|
Logic changed and table updated. |
Member
|
Perfect, thank you |
dcreager
added a commit
that referenced
this pull request
Dec 10, 2024
* main: [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887) Improve mdtests style (#14884) Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888) [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408) [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824) [red-knot] Improve type inference for except handlers (#14838) More typos found by codespell (#14880) [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879) [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832) Stop referring to early ruff versions (#14862) Fix a typo in `class.rs` (#14877) [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801) [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871) [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of the big change introduced in #14828. This temporarily causes all fixes for
round(...)to be considered unsafe, but they will eventually be enhanced.Test Plan
cargo nextest runandcargo insta test.