Understand type[A | B] special form in annotations#14830
Merged
carljm merged 2 commits intoastral-sh:mainfrom Dec 7, 2024
Merged
Understand type[A | B] special form in annotations#14830carljm merged 2 commits intoastral-sh:mainfrom
type[A | B] special form in annotations#14830carljm merged 2 commits intoastral-sh:mainfrom
Conversation
Glyphack
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
Glyphack
force-pushed
the
typing-type-union
branch
from
d191f16 to
aea36f0
Compare
Glyphack
force-pushed
the
typing-type-union
branch
from
aea36f0 to
10bdf5f
Compare
Contributor
|
carljm
approved these changes
Dec 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #14703
I decided to use recursion to get the type, so if anything is added to the single element inference it will be applied for the union.
Also added this change in this PR since it was easy.