Merged
Conversation
sharkdp
requested review from
AlexWaygood,
MichaReiser and
carljm
as code owners
AlexWaygood
approved these changes
Dec 4, 2024
| assert_eq!(a_not_b.pos_vec(&db), &[a]); | ||
| assert_eq!(a_not_b.neg_vec(&db), &[b]); | ||
|
|
||
| // let's build |
Member
There was a problem hiding this comment.
Suggested change
| // let's build | |
| // let's build 👷 |
Contributor
|
dcreager
added a commit
that referenced
this pull request
Dec 4, 2024
* main: [red-knot] Test: Hashable/Sized => A/B (#14769) [`flake8-type-checking`] Expands TC006 docs to better explain itself (#14749) [`pycodestyle`] Handle f-strings properly for `invalid-escape-sequence (W605)` (#14748) [red-knot] Add fuzzer to catch panics for invalid syntax (#14678) Check `AIR001` from builtin or providers `operators` module (#14631) [airflow]: extend removed names (AIR302) (#14734)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor change that uses two plain classes
AandBinstead oftyping.Sizedandtyping.Hashable.The motivation is twofold: I remember that I was confused when I first saw this test. Was there anything specific to
SizedandHashablethat was relevant here? (there is, these classes are not overlapping; and you can build a proper intersection from them; but that's true for almost all non-builtin classes).I now ran into another problem while working on #14758:
SizedandHashableare protocols that we don't fully understand yet. This causing some trouble when trying to infer whether these are fully-static types or not.