[airflow]: extend removed names (AIR302)#14734
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Dec 3, 2024
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR302 | 2 | 1 | 1 | 0 | 0 |
uranusjr
reviewed
Dec 3, 2024
uranusjr
reviewed
Dec 3, 2024
Comment on lines
118
to
120
| ["airflow", "utils", "decorators", "apply_defaults"] => { | ||
| Some((qualname.to_string(), Replacement::None)) | ||
| } |
Contributor
There was a problem hiding this comment.
We should mention this can be safely removed (apply_defaults is now unconditionally done). It’s probably easier if we add a variant to Replacement (called Message maybe) and do
Replacement::Message(message) => {
format!("`{deprecated}` is removed in Airflow 3.0; {message}")
}in impl Violation.
Contributor
Author
There was a problem hiding this comment.
Yep, we'll need something similar for AIR303 and AIR304 as well. or we could probably use this for those 2 🤔
Contributor
Author
There was a problem hiding this comment.
This is temporarily removed, but will be added back (probably in the next PR I think?)
* airflow.metrics.validators.AllowListValidator * airflow.metrics.validators.BlockListValidator * airflow.utils.dates.parse_execution_date * airflow.utils.dates.round_time * airflow.utils.dates.scale_time_units * airflow.utils.dates.infer_time_unit * airflow.utils.file.TemporaryDirectory * airflow.utils.file.mkdirs * airflow.www.auth.has_access * airflow.api_connexion.security.requires_access * airflow.utils.dag_cycle_tester.test_cycle * airflow.utils.state.SHUTDOWN * airflow.utils.state.terminating_states
Lee-W
force-pushed
the
extend-air-302-removed-names
branch
from
d37fbad to
897ac7f
Compare
Lee-W
changed the title
MichaReiser
added
rule
dcreager
added a commit
that referenced
this pull request
Dec 4, 2024
* main: [red-knot] Test: Hashable/Sized => A/B (#14769) [`flake8-type-checking`] Expands TC006 docs to better explain itself (#14749) [`pycodestyle`] Handle f-strings properly for `invalid-escape-sequence (W605)` (#14748) [red-knot] Add fuzzer to catch panics for invalid syntax (#14678) Check `AIR001` from builtin or providers `operators` module (#14631) [airflow]: extend removed names (AIR302) (#14734)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR deprecates the following names.
The full list of names we will extend apache/airflow#44556
Test Plan
A test fixture is included in the PR.