[red-knot] Deeper understanding of LiteralString#14649
Merged
carljm merged 6 commits intoastral-sh:mainfrom Dec 3, 2024
Merged
[red-knot] Deeper understanding of LiteralString#14649carljm merged 6 commits intoastral-sh:mainfrom
LiteralString#14649carljm merged 6 commits intoastral-sh:mainfrom
Conversation
InSyncWithFoo
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
Contributor
|
carljm
requested changes
Nov 28, 2024
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I appreciate the thorough tests, but it is possible to have too many tests :) We should make sure that each test, and each part of each test, is asserting something meaningful about the added feature. Usually added tests should fail without the code added in the PR, unless the PR is specifically about improving test coverage for existing features.
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Outdated
Show resolved
Hide resolved
carljm
approved these changes
Dec 3, 2024
crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md
Outdated
Show resolved
Hide resolved
dcreager
added a commit
that referenced
this pull request
Dec 3, 2024
* main: [`ruff`] Extend unnecessary-regular-expression to non-literal strings (`RUF055`) (#14679) Minor followups to RUF052 (#14755) [red-knot] Property tests (#14178) [red-knot] `is_subtype_of` fix for `KnownInstance` types (#14750) Improve docs for flake8-use-pathlib rules (#14741) [`ruff`] Implemented `used-dummy-variable` (`RUF052`) (#14611) [red-knot] Simplify tuples containing `Never` (#14744) Possible fix for flaky file watching test (#14543) [`flake8-import-conventions`] Improve syntax check for aliases supplied in configuration for `unconventional-import-alias (ICN001)` (#14745) [red-knot] Deeper understanding of `LiteralString` (#14649) red-knot: support narrowing for bool(E) (#14668) [`refurb`] Handle non-finite decimals in `verbose-decimal-constructor (FURB157)` (#14596) [red-knot] Re-enable linter corpus tests (#14736)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14648.
Test Plan
Markdown tests.