Check AIR001 from builtin or providers operators module#14631
Merged
dhruvmanila merged 1 commit intomainfrom Dec 4, 2024
Merged
Check AIR001 from builtin or providers operators module#14631dhruvmanila merged 1 commit intomainfrom
AIR001 from builtin or providers operators module#14631dhruvmanila merged 1 commit intomainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR001 | 678 | 0 | 678 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -678 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
apache/airflow (+0 -678 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/example_dags/example_dynamic_task_mapping_with_no_taskflow_operators.py:64:5: AIR001 Task variable name should match the `task_id`: "sum_it" - airflow/example_dags/example_sensors.py:102:5: AIR001 Task variable name should match the `task_id`: "wait_for_file_async" - airflow/example_dags/example_sensors.py:112:5: AIR001 Task variable name should match the `task_id`: "success_sensor_python" - airflow/example_dags/example_sensors.py:114:5: AIR001 Task variable name should match the `task_id`: "failure_timeout_sensor_python" - airflow/example_dags/example_sensors.py:120:5: AIR001 Task variable name should match the `task_id`: "week_day_sensor_failing_on_timeout" - airflow/example_dags/example_sensors.py:56:5: AIR001 Task variable name should match the `task_id`: "wait_some_seconds" - airflow/example_dags/example_sensors.py:60:5: AIR001 Task variable name should match the `task_id`: "wait_some_seconds_async" - airflow/example_dags/example_sensors.py:64:5: AIR001 Task variable name should match the `task_id`: "fire_immediately" - airflow/example_dags/example_sensors.py:68:5: AIR001 Task variable name should match the `task_id`: "timeout_after_second_date_in_the_future" - airflow/example_dags/example_sensors.py:77:5: AIR001 Task variable name should match the `task_id`: "fire_immediately_async" - airflow/example_dags/example_sensors.py:81:5: AIR001 Task variable name should match the `task_id`: "timeout_after_second_date_in_the_future_async" - airflow/example_dags/example_sensors.py:90:5: AIR001 Task variable name should match the `task_id`: "Sensor_succeeds" - airflow/example_dags/example_sensors.py:92:5: AIR001 Task variable name should match the `task_id`: "Sensor_fails_after_3_seconds" - airflow/example_dags/example_sensors.py:98:5: AIR001 Task variable name should match the `task_id`: "wait_for_file" - providers/src/airflow/providers/arangodb/example_dags/example_arangodb.py:34:1: AIR001 Task variable name should match the `task_id`: "aql_sensor" - providers/src/airflow/providers/arangodb/example_dags/example_arangodb.py:46:1: AIR001 Task variable name should match the `task_id`: "aql_sensor_template_file" - providers/src/airflow/providers/google/cloud/example_dags/example_cloud_task.py:48:5: AIR001 Task variable name should match the `task_id`: "gcp_sense_cloud_tasks_empty" - providers/src/airflow/providers/google/cloud/example_dags/example_facebook_ads_to_gcs.py:102:5: AIR001 Task variable name should match the `task_id`: "gcs_to_bq_example" - providers/src/airflow/providers/google/cloud/example_dags/example_facebook_ads_to_gcs.py:91:5: AIR001 Task variable name should match the `task_id`: "run_fetch_data" - providers/src/airflow/providers/google/cloud/example_dags/example_salesforce_to_gcs.py:60:5: AIR001 Task variable name should match the `task_id`: "upload_to_gcs" - providers/src/airflow/providers/google/cloud/example_dags/example_salesforce_to_gcs.py:95:5: AIR001 Task variable name should match the `task_id`: "gcs_to_bq" - providers/tests/amazon/aws/sensors/test_batch.py:111:9: AIR001 Task variable name should match the `task_id`: "batch_job_sensor" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:108:9: AIR001 Task variable name should match the `task_id`: "cf_delete_stack_init" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:119:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:124:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:129:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:135:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:44:9: AIR001 Task variable name should match the `task_id`: "cf_create_stack_init" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:61:9: AIR001 Task variable name should match the `task_id`: "cf_create_stack_init" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:70:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:75:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:80:9: AIR001 Task variable name should match the `task_id`: "task" - providers/tests/amazon/aws/sensors/test_cloud_formation.py:91:9: AIR001 Task variable name should match the `task_id`: "cf_delete_stack_init" - providers/tests/amazon/aws/sensors/test_dms.py:61:9: AIR001 Task variable name should match the `task_id`: "create_task" - providers/tests/amazon/aws/sensors/test_dynamodb.py:155:9: AIR001 Task variable name should match the `task_id`: "dynamodb_value_sensor_init" - providers/tests/amazon/aws/sensors/test_dynamodb.py:178:9: AIR001 Task variable name should match the `task_id`: "dynamodb_value_sensor_init" - providers/tests/amazon/aws/sensors/test_ec2.py:30:9: AIR001 Task variable name should match the `task_id`: "task_test" - providers/tests/amazon/aws/sensors/test_ecs.py:84:9: AIR001 Task variable name should match the `task_id`: "test_ecs_base" - providers/tests/amazon/aws/sensors/test_ecs.py:95:9: AIR001 Task variable name should match the `task_id`: "test_ecs_base_hook_client" - providers/tests/amazon/aws/sensors/test_emr_job_flow.py:207:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_job_flow.py:226:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_job_flow.py:248:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_job_flow.py:265:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_notebook_execution.py:44:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_notebook_execution.py:56:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_notebook_execution.py:70:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_emr_step.py:205:9: AIR001 Task variable name should match the `task_id`: "test_task" - providers/tests/amazon/aws/sensors/test_glue.py:120:9: AIR001 Task variable name should match the `task_id`: "test_glue_job_sensor" - providers/tests/amazon/aws/sensors/test_glue.py:141:9: AIR001 Task variable name should match the `task_id`: "test_glue_job_sensor" - providers/tests/amazon/aws/sensors/test_glue.py:36:9: AIR001 Task variable name should match the `task_id`: "test_glue_job_sensor" ... 628 additional changes omitted for project
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR001 | 678 | 0 | 678 | 0 | 0 |
Member
|
CC: @uranusjr |
Member
|
That's a lot of removed diagnostics |
Member
Author
Oops, you meant the ecosystem changes and not the snapshot changes. |
dhruvmanila
commented
Nov 27, 2024
Comment on lines
10
to
-9
| my_task = PythonOperator(task_id="my_task", callable=my_callable) | ||
| my_task_2 = PythonOperator(callable=my_callable, task_id="my_task_2") |
Member
Author
There was a problem hiding this comment.
cc @MichaReiser these two test cases are identical except that the arguments are reversed.
Member
|
Yeah. I'd like for @uranusjr to have a look at the ecosystem changes. I worry that we just removed many true-positives, because Ruff can't see through other import/classes. |
Member
|
@uranusjr sorry for pinging you again. Would you mind taking a look at the ecosystem changes? I want to make sure that we don't regress an airflow rule. |
MichaReiser
approved these changes
Dec 4, 2024
Member
|
See #14626 (comment) |
Contributor
|
I’m late, but this looks good to me as well. Awesome work. |
dcreager
added a commit
that referenced
this pull request
Dec 4, 2024
* main: [red-knot] Test: Hashable/Sized => A/B (#14769) [`flake8-type-checking`] Expands TC006 docs to better explain itself (#14749) [`pycodestyle`] Handle f-strings properly for `invalid-escape-sequence (W605)` (#14748) [red-knot] Add fuzzer to catch panics for invalid syntax (#14678) Check `AIR001` from builtin or providers `operators` module (#14631) [airflow]: extend removed names (AIR302) (#14734)
Member
Author
No worries, thanks for looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes changes to the
AIR001rule as per #14627 (comment).Additionally,
Diagnosticand update the checker in the rule logic for consistencyTest Plan
Add test cases for multiple operators from various modules.