Gate is_multiline change behind preview#14630
Merged
dhruvmanila merged 1 commit intomainfrom Nov 27, 2024
Merged
Conversation
dhruvmanila
added
formatter
dhruvmanila
commented
Nov 27, 2024
| context.source().contains_line_break(literal.range()) | ||
| } | ||
| ast::FStringElement::Expression(expression) => { | ||
| if is_f_string_formatting_enabled(context) { |
Member
Author
There was a problem hiding this comment.
The change in this diff block removes the else block because the entire function call is behind is_f_string_formatting_enabled check.
MichaReiser
approved these changes
Nov 27, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #14624 (review)
Test Plan
The test case in the follow-up PR showcases the difference between preview and non-preview formatting: https://github.com/astral-sh/ruff/pull/14624/files#diff-dc25bd4df280d9a9180598075b5bc2d0bac30af956767b373561029309c8f024