[refurb] Handle non-finite decimals in verbose-decimal-constructor (FURB157)#14596
Merged
dylwil3 merged 11 commits intoastral-sh:mainfrom Dec 3, 2024
Merged
[refurb] Handle non-finite decimals in verbose-decimal-constructor (FURB157)#14596dylwil3 merged 11 commits intoastral-sh:mainfrom
refurb] Handle non-finite decimals in verbose-decimal-constructor (FURB157)#14596dylwil3 merged 11 commits intoastral-sh:mainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Nov 26, 2024
crates/ruff_linter/src/rules/refurb/rules/verbose_decimal_constructor.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/refurb/rules/verbose_decimal_constructor.rs
Show resolved
Hide resolved
Co-authored-by: Micha Reiser <[email protected]>
dcreager
added a commit
that referenced
this pull request
Dec 3, 2024
* main: [`ruff`] Extend unnecessary-regular-expression to non-literal strings (`RUF055`) (#14679) Minor followups to RUF052 (#14755) [red-knot] Property tests (#14178) [red-knot] `is_subtype_of` fix for `KnownInstance` types (#14750) Improve docs for flake8-use-pathlib rules (#14741) [`ruff`] Implemented `used-dummy-variable` (`RUF052`) (#14611) [red-knot] Simplify tuples containing `Never` (#14744) Possible fix for flaky file watching test (#14543) [`flake8-import-conventions`] Improve syntax check for aliases supplied in configuration for `unconventional-import-alias (ICN001)` (#14745) [red-knot] Deeper understanding of `LiteralString` (#14649) red-knot: support narrowing for bool(E) (#14668) [`refurb`] Handle non-finite decimals in `verbose-decimal-constructor (FURB157)` (#14596) [red-knot] Re-enable linter corpus tests (#14736)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the Decimal parsing used in verbose-decimal-constructor (FURB157) to better handle non-finite
Decimalobjects, avoiding some false negatives.Closes #14587