[airflow] Avoid deprecated values (AIR302)#14582
Merged
MichaReiser merged 5 commits intoastral-sh:mainfrom Dec 2, 2024
Merged
Conversation
uranusjr
force-pushed
the
airflow-member-removals
branch
2 times, most recently
from
111ee16 to
b3642c3
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR302 | 1 | 1 | 0 | 0 | 0 |
| AIR301 | 1 | 0 | 1 | 0 | 0 |
MichaReiser
added
rule
MichaReiser
approved these changes
Nov 25, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
This is great. Thank you. I've two small questions/suggestions.
crates/ruff_linter/src/rules/airflow/rules/deprecated_members.rs
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 25, 2024
crates/ruff_linter/src/rules/airflow/rules/deprecated_members.rs
Outdated
Show resolved
Hide resolved
Member
|
Feel free to ping me when you rebased the PR and I'll merge it. This is great work. |
uranusjr
force-pushed
the
airflow-member-removals
branch
2 times, most recently
from
4843c41 to
1f5ec14
Compare
Contributor
Author
|
Alright, I’ve added argument deprecation to AIR302. I also added some structure in the module since we’re probably going to add other kinds of deprecation (like |
dhruvmanila
reviewed
Nov 27, 2024
uranusjr
force-pushed
the
airflow-member-removals
branch
from
87f000b to
352feb4
Compare
MichaReiser
reviewed
Nov 29, 2024
uranusjr
force-pushed
the
airflow-member-removals
branch
from
6baabb0 to
b9fe68c
Compare
Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect.
When a deprecated schedule argument is found on a DAG, it is more appropriate to emit an AIR302 to signify a rename, instead of telling the user to add a 'schedule' argument (which won't work unless they also remove the deprecated argument).
MichaReiser
force-pushed
the
airflow-member-removals
branch
from
b9fe68c to
3f381e6
Compare
dhruvmanila
added a commit
that referenced
this pull request
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect.
(We are deprecating a lot more things. I want to use this to establish a basic structure so future checks can be submitted more easily.)
Ref: #14626
Test Plan
A test fixture is included in the PR.