Remove the deprecated E999 rule code#14428
Merged
AlexWaygood merged 2 commits intoruff-0.8from Nov 19, 2024
Merged
Conversation
MichaReiser
added
breaking
MichaReiser
force-pushed
the
micha/remove-syntax-error-rule-code
branch
from
4710d6b to
c239464
Compare
Contributor
|
AlexWaygood
reviewed
Nov 18, 2024
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Overall this LGTM. The ecosystem output is noisy because you changed the target branch after filing the PR, but it doesn't look like there's anything E999-related in there!
I think there's still two references to E999 elsewhere in the repo that we should get rid of:
crates/ruff/tests/integration_test.rs: // Select any rule except for `E999`, syntax error should still be shown.
crates/ruff_workspace/src/configuration.rs: if matches!(rule.as_str(), "E999") {
MichaReiser
force-pushed
the
ruff-0.8
branch
from
10c6a2a to
5532cc0
Compare
MichaReiser
force-pushed
the
micha/remove-syntax-error-rule-code
branch
2 times, most recently
from
c532214 to
409e516
Compare
MichaReiser
force-pushed
the
micha/remove-syntax-error-rule-code
branch
from
409e516 to
539a6ab
Compare
AlexWaygood
approved these changes
Nov 19, 2024
Merged
AlexWaygood
pushed a commit
that referenced
this pull request
Nov 19, 2024
MichaReiser
added a commit
that referenced
this pull request
Nov 20, 2024
MichaReiser
added a commit
that referenced
this pull request
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
E999rule code was deprecated as part of Ruff 0.5.This PR now removes it entirely. Using
E999is now a hard error.Test Plan
cargo test