[flake8-bugbear] itertools.batched() without explicit strict (B911)#14408
Merged
MichaReiser merged 6 commits intoastral-sh:mainfrom Dec 10, 2024
Merged
[flake8-bugbear] itertools.batched() without explicit strict (B911)#14408MichaReiser merged 6 commits intoastral-sh:mainfrom
flake8-bugbear] itertools.batched() without explicit strict (B911)#14408MichaReiser merged 6 commits intoastral-sh:mainfrom
Conversation
Contributor
|
dhruvmanila
added
rule
Member
|
I think I prefer to wait with adding this rule and see if it gets accepted upstream to avoid having to re-code in a few days/weeks. See PyCQA/flake8-bugbear#498 |
InSyncWithFoo
changed the title
ruff] itertools.batched() without explicit strict (RUF054)flake8-bugbear] itertools.batched() without explicit strict (B911)
MichaReiser
approved these changes
Dec 9, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
This is great.
We have to decide on the fix safety and polish the documentation a bit.
crates/ruff_linter/src/rules/flake8_bugbear/rules/batched_without_explicit_strict.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bugbear/rules/batched_without_explicit_strict.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bugbear/rules/batched_without_explicit_strict.rs
Outdated
Show resolved
Hide resolved
Member
|
@AlexWaygood requesting review from you regarding the open question around fix safety (and whether we should raise a diagnostic). I already reviewed the code changes |
dcreager
added a commit
that referenced
this pull request
Dec 10, 2024
* main: [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887) Improve mdtests style (#14884) Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888) [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408) [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824) [red-knot] Improve type inference for except handlers (#14838) More typos found by codespell (#14880) [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879) [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832) Stop referring to early ruff versions (#14862) Fix a typo in `class.rs` (#14877) [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801) [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871) [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14387.
Test Plan
cargo nextest runandcargo insta test.