fix issues in discovering ruff in pip build environments#13881
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Oct 29, 2024
Merged
fix issues in discovering ruff in pip build environments#13881charliermarsh merged 3 commits intoastral-sh:mainfrom
charliermarsh merged 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
gaborbernat
reviewed
Oct 22, 2024
Contributor
gaborbernat
left a comment
There was a problem hiding this comment.
Needs some work IMHO.
gaborbernat
reviewed
Oct 22, 2024
181c987 to
4e67901
Compare
Member
charliermarsh
left a comment
There was a problem hiding this comment.
What was the actual problem here?
Contributor
gaborbernat
reviewed
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes in this PR #13591 did not allow correct discovery in pip build environments.
Here we instead usepathlib, and we check allpip-build-env-paths for the folder that is expected to contain theruffexecutable.Here we update the logic to more properly split out the path components that we use for
pip-build-env-inspection.Test Plan
I've checked this manually against a workflow that was failing, I'm not sure what to do for real tests. The same issues apply as with the previous PR.