Conversation
|
T-256
left a comment
T-256
left a comment
There was a problem hiding this comment.
There is circular imports concept in Python, do you plan support it into mdtests?
I'm not sure what extra support mdtests would need for circular imports? It allows you to create whatever Python files you like with whatever contents you like, so you can create and test any circular import scenario you would want. |
Co-authored-by: T-256 <[email protected]>
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you!! This is extremely valuable.
Despite having previously reviewed your proposal for this framework in Notion, and the actual implementation, it actually made me realise there were several aspects I wasn't aware of before reading this :-)
Some comments below, none huge:
Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Dhruv Manilawala <[email protected]>
|
Ok, pushed an updated that I think addresses all comments. I also realized in working on the change to require either rule or message-contains, that when a diagnostic doesn't match any assertion we should include its actual column in the "unexpected error" output, otherwise it's hard to debug a failure to match on the column, so I made this change as well. And in the course of making that change, I realized that some tests were not using |
|
Thanks for the thorough review! |
4 participants
This adds documentation for the new test framework.
I also added documentation for the planned design of features we haven't built yet (clearly marked as such), so that this doc can become the sole source of truth for the test framework design (we don't need to refer back to the original internal design document.)
Also fixes a few issues in the test framework implementation that were discovered in writing up the docs.