Skip to content

Comments

Remove ecosystem_ci flag from Ruff CLI#12596

Merged
zanieb merged 1 commit intoastral-sh:mainfrom
chriskrycho:drop_ecosystem_ci
Jul 31, 2024
Merged

Remove ecosystem_ci flag from Ruff CLI#12596
zanieb merged 1 commit intoastral-sh:mainfrom
chriskrycho:drop_ecosystem_ci

Conversation

@chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Jul 31, 2024

Summary

@zanieb noticed while we were discussing #12595 that this flag is now unnecessary, so remove it and the flags which reference it.

Test Plan

Question for maintainers: is there a test to add or remove here? (I’ve opened this as a draft PR with that in view!)

@chriskrycho
Remove ecosystem_ci flag from Ruff CLI
e0f5836 
We noticed while implementing #12595 that this flag is now unnecessary,
so remove it and the flags which reference it.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

warning: Detected debug build without --no-cache.
error: Failed to parse examples/Chat_finetuning_data_prep.ipynb:6:18:25: Unparenthesized generator expression cannot be used here
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_Notion.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_gmail.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_jira.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_doc.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_text.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_middleware_azure_function.ipynb:37:1:13: Simple statements must be separated by newlines or semicolons

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to parse examples/Chat_finetuning_data_prep.ipynb:6:18:25: Unparenthesized generator expression cannot be used here
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_Notion.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_gmail.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_jira.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_doc.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_text.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_middleware_azure_function.ipynb:37:1:13: Simple statements must be separated by newlines or semicolons

charliermarsh
charliermarsh approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should be fine as long as the ecosystem checks pass.

@zanieb zanieb added the internal An internal refactor or improvement label Jul 31, 2024
@zanieb zanieb marked this pull request as ready for review July 31, 2024 16:39
@zanieb zanieb merged commit c1bc7f4 into astral-sh:main Jul 31, 2024
@chriskrycho chriskrycho deleted the drop_ecosystem_ci branch July 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriskrycho @charliermarsh @zanieb