Re-code `unnecessary-dict-comprehension-for-iterable` (`RUF025`) as `C420` by charliermarsh · Pull Request #12533 · astral-sh/ruff

charliermarsh · 2024-07-26T14:36:08Z

Summary

Closes #12110.

github-actions · 2024-07-26T16:05:05Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+19 -19 violations, +0 -0 fixes in 15 projects; 39 projects unchanged)

DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ disnake/ext/commands/flag_converter.py:314:28: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- disnake/ext/commands/flag_converter.py:314:28: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

RasaHQ/rasa (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- rasa/core/evaluation/marker_stats.py:114:51: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- rasa/core/featurizers/single_state_featurizer.py:119:20: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- tests/core/featurizers/test_precomputation.py:110:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

PlasmaPy/PlasmaPy (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/plasmapy/particles/ionization_state_collection.py:693:40: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

apache/airflow (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ helm_tests/airflow_aux/test_annotations.py:409:63: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- helm_tests/airflow_aux/test_annotations.py:409:63: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ tests/ti_deps/deps/test_mapped_task_upstream_dep.py:459:36: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- tests/ti_deps/deps/test_mapped_task_upstream_dep.py:459:36: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

apache/superset (+3 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/reports/notifications/email.py:58:28: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- superset/reports/notifications/email.py:58:28: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ superset/reports/notifications/slack_mixin.py:107:43: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- superset/reports/notifications/slack_mixin.py:107:43: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ superset/reports/notifications/slack_mixin.py:97:39: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- superset/reports/notifications/slack_mixin.py:97:39: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

bokeh/bokeh (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ src/bokeh/command/subcommands/file_output.py:145:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- src/bokeh/command/subcommands/file_output.py:145:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ src/bokeh/command/subcommands/serve.py:831:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- src/bokeh/command/subcommands/serve.py:831:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

docker/docker-py (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ docker/types/containers.py:725:22: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

ibis-project/ibis (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ ibis/common/egraph.py:776:17: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- ibis/common/egraph.py:776:17: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

mlflow/mlflow (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/metrics/genai/test_genai_metrics.py:554:37: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

pypa/build (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/build/__main__.py:40:14: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- src/build/__main__.py:40:14: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

pypa/pip (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/pip/_internal/locations/_sysconfig.py:164:21: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ src/pip/_internal/locations/_sysconfig.py:166:21: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

scikit-build/scikit-build (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ skbuild/setuptools_wrap.py:516:22: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- skbuild/setuptools_wrap.py:516:22: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
+ skbuild/setuptools_wrap.py:519:19: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- skbuild/setuptools_wrap.py:519:19: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

scikit-build/scikit-build-core (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/scikit_build_core/_logging.py:118:14: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- src/scikit_build_core/_logging.py:118:14: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

pytest-dev/pytest (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- src/_pytest/logging.py:128:24: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- src/_pytest/reports.py:345:20: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
- testing/conftest.py:191:21: RUF025 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

mesonbuild/meson-python (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ mesonpy/__init__.py:570:24: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
C420	19	19	0	0	0
RUF025	19	0	19	0	0

Skylion007

LGTM

…C420` (#12533) Closes #12110.

charliermarsh added this to the v0.6 milestone Jul 26, 2024

charliermarsh added the rule Implementing or modifying a lint rule label Jul 26, 2024

Re-code RUF025 as C420

d1fef4c

charliermarsh force-pushed the charlie/c420 branch from 1f075b8 to d1fef4c Compare July 26, 2024 15:51

Skylion007 reviewed Jul 27, 2024

View reviewed changes

MichaReiser added the breaking Breaking API change label Jul 29, 2024

MichaReiser approved these changes Jul 29, 2024

View reviewed changes

MichaReiser changed the base branch from main to ruff-0.6 August 12, 2024 09:26

MichaReiser merged commit 4ec340a into ruff-0.6 Aug 12, 2024

MichaReiser deleted the charlie/c420 branch August 12, 2024 09:27

MichaReiser mentioned this pull request Aug 13, 2024

Ruff 0.6 #12834

Merged

AlexWaygood pushed a commit that referenced this pull request Aug 14, 2024

Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…

10c58a2

…C420` (#12533) Closes #12110.

MichaReiser pushed a commit that referenced this pull request Aug 14, 2024

Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…

e4de0e9

…C420` (#12533) Closes #12110.

MichaReiser pushed a commit that referenced this pull request Aug 14, 2024

Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…

78a7ac0

…C420` (#12533) Closes #12110.

oprypin mentioned this pull request Jan 4, 2025

RUF025 is remapped to C420 but now it's also a new rule #15255

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Re-code `unnecessary-dict-comprehension-for-iterable` (`RUF025`) as `C420`#12533

Re-code `unnecessary-dict-comprehension-for-iterable` (`RUF025`) as `C420`#12533
MichaReiser merged 1 commit intoruff-0.6from
charlie/c420

charliermarsh commented Jul 26, 2024

Uh oh!

github-actions bot commented Jul 26, 2024

Uh oh!

Skylion007 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

charliermarsh commented Jul 26, 2024

Summary

Uh oh!

github-actions bot commented Jul 26, 2024

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`ruff-ecosystem` results