Fix cargo build --release#11177
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Apr 27, 2024
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
Apr 27, 2024
Member
|
Seems fine for now, merging to get builds passing. Thanks! |
charliermarsh
added a commit
that referenced
this pull request
Apr 28, 2024
AlexWaygood
added a commit
that referenced
this pull request
Apr 30, 2024
…ache` (#11179) ## Summary This PR changes the `DebugStatistics` and `ReleaseStatistics` structs so that they implement a common `StatisticsRecorder` trait, and makes the `KeyValueCache` struct generic over a type parameter bound to that trait. The advantage of this approach is that it's much harder for the `DebugStatistics` and `ReleaseStatistics` structs to accidentally grow out of sync in the methods that they implement, which was the cause of the release-build failure recently fixed in #11177. ## Test Plan `cargo test -p red_knot` and `cargo build --release` both continue to pass for me locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo build --releasecurrently fails to compile onmain:Details
This is because in a release build,
CacheStatisticsis a type alias forReleaseStatistics, andReleaseStatisticsdoesn't havehit()ormiss()methods. (In a debug build,CacheStatisticsis a type alias forDebugStatistics, which does have those methods.)Possibly we could make this less likely to happen in the future by making both structs implement a common trait instead of using type aliases that vary depending on whether it's a debug build or not? For now, though, this PR just brings the two structs in sync w.r.t. the methods they expose.
Test Plan
cargo build --releasenow once again compiles for me locally