Skip to content

Comments

Remove deprecated CLI option --format#10170

Merged
MichaReiser merged 1 commit intomainfrom
remove-format-cli-option
Feb 29, 2024
Merged

Remove deprecated CLI option --format#10170
MichaReiser merged 1 commit intomainfrom
remove-format-cli-option

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Feb 29, 2024 •
edited
Loading

Summary

Extracted from #9814

Removes the deprecated CLI option 'format' in favor of output-format. The option was deprecated in #8203

Test Plan

cargo run -p ruff -- --explain RET505 #  works
cargo run -p ruff -- --explain RET505 --output-format json # works
cargo run -p ruff -- --explain RET505 --format json # does not work anymore
error: unexpected argument '--format' found

  tip: to pass '--format' as a value, use '-- --format'

@MichaReiser MichaReiser added this to the v0.3.0 milestone Feb 29, 2024
@MichaReiser MichaReiser added breaking Breaking API change cli Related to the command-line interface labels Feb 29, 2024
@MichaReiser MichaReiser marked this pull request as ready for review February 29, 2024 13:54
@MichaReiser
Copy link
Member Author

MichaReiser commented Feb 29, 2024

Thanks @tibor-reiss

@MichaReiser MichaReiser enabled auto-merge (squash) February 29, 2024 13:57
@MichaReiser MichaReiser merged commit 52f4c1e into main Feb 29, 2024
@MichaReiser MichaReiser deleted the remove-format-cli-option branch February 29, 2024 13:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request Feb 29, 2024
Merged
@tibor-reiss tibor-reiss mentioned this pull request Mar 1, 2024
Merged
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
@MichaReiser @tibor-reiss @nkxxll
Remove deprecated CLI option --format (astral-sh#10170)
dd6499a 
Co-authored-by: Tibor Reiss <[email protected]>
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees

No one assigned

Labels

breaking Breaking API change cli Related to the command-line interface

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @tibor-reiss