-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
In astropy/astropy#15385 we are trying to fix some __all__ statements and ran into the following
__all__ = [...]
logging_levels = ["NOTSET", ...]
...
__all__ += logging_levelsMy suggested fix was
__all__ = [...]
__all__ += (logging_levels := ["NOTSET", ...])However PLE0605 is still complaining. I don't think this is correct since the above should be, from the "perspective" of __all__ equivalent to
__all__ = [...]
__all__ += ["NOTSET", ...]which passes the check.
The inclusion of the walrus operator for assigning to another variable makes the AST more complicated but should be equivalent statically to excluding the walrus.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working