-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
PEP 701 in the lexer and parser is complete, and it's time to move on to make the necessary changes in the linter. This will mainly involve token-based rules or anything which uses the lexer in some way. The work items section contains a list of issues which needs to be fixed.
The lexer and parser changes cannot be merged without making the necessary changes across the linter. This is the reason that any pull requests which is made to fix any of the following issues needs to be based on the latest parser changes which as of this writing is #7263 (branch dhruv/fstring-parser-3). The risk here for any external contributor are:
- The contributor will have to base their branch on the latest parser branch (
dhruv/fstring-parser-3) - If there are any changes made to the base branch, which is unlikely as of now, the downstream branches needs to be rebased as well
With the above points in mind, an external contributor may choose to work on any of the mentioned issues. If so, please comment on the respective issue to be assigned. Feel free to reach out for any kind of queries either here on GitHub or on Discord.
Workflow
What would working on these issues look like?
git checkout maingit pull- Make sure to be on the latest changesgit checkout -b fix-issue-xxxx dhruv/fstring-parser-3- Create a local branch based on the latest f-string parser branch- Work on the respective issue, commit the changes and open a pull request.
Work items
- Update
Indexerto use new tokens to compute the ranges #7290 - Detect
noqadirectives inside f-strings #7291 - Update
F541to use new tokens to detect f-strings #7292 - Update
Stylistquote detection to use the new f-string tokens #7293 - Update
RUF001-003to check in f-strings #7294 - Update
W605to check in f-strings #7295 - Update
PLE2510,PLE2512-2515to check in f-strings #7296 - Update
flake8_quotesto account for the new f-string tokens #7297 - Update
ISC001,ISC002to check in f-strings #7298