-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
python312Related to Python 3.12Related to Python 3.12ruleImplementing or modifying a lint ruleImplementing or modifying a lint rule
Description
ISC001 and ISC002 checks for implicitly concatenated strings over a single or multiple lines.
The rules needs to be updated to account for the f-strings. The implementation using ranges to check if 2 consecutive strings are implicitly concatenated.
Proposed solution
- We'll need to get the f-string range from the
Indexerwhen we encounter aFStringStarttoken. - Another solution would be to consume all of the tokens from
FStringStarttoFStringEndto get the range. I think using theIndexeris better.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
python312Related to Python 3.12Related to Python 3.12ruleImplementing or modifying a lint ruleImplementing or modifying a lint rule