Curious of what a solution would look like. These are line suffixes, so would we want to just match on the content that'd we want to ignore? Or is there a more robust way to go about this?

No, matching on the content is what we'll need to do here. Similar to how formatter suppression comments:

ruff/crates/ruff_python_formatter/src/comments/mod.rs

Lines 173 to 193 in 0cea497

    
           pub(crate) fn suppression_kind(&self, source: &str) -> Option<SuppressionKind> { 
        
               let text = self.slice.text(SourceCode::new(source)); 
        
               let trimmed = text.strip_prefix('#').unwrap_or(text).trim_whitespace(); 
        
               if let Some(command) = trimmed.strip_prefix("fmt:") { 
        
                   match command.trim_whitespace_start() { 
        
                       "off" => Some(SuppressionKind::Off), 
        
                       "on" => Some(SuppressionKind::On), 
        
                       "skip" => Some(SuppressionKind::Skip), 
        
                       _ => None, 
        
                   } 
        
               } else if let Some(command) = trimmed.strip_prefix("yapf:") { 
        
                   match command.trim_whitespace_start() { 
        
                       "disable" => Some(SuppressionKind::Off), 
        
                       "enable" => Some(SuppressionKind::On), 
        
                       _ => None, 
        
                   } 
        
               } else { 
        
                   None 
        
               } 
        
           }

We'll match on the content and set reserved width to 0 if it is a pragma comment.

	pub(crate) fn suppression_kind(&self, source: &str) -> Option<SuppressionKind> {
	let text = self.slice.text(SourceCode::new(source));
	let trimmed = text.strip_prefix('#').unwrap_or(text).trim_whitespace();

	if let Some(command) = trimmed.strip_prefix("fmt:") {
	match command.trim_whitespace_start() {
	"off" => Some(SuppressionKind::Off),
	"on" => Some(SuppressionKind::On),
	"skip" => Some(SuppressionKind::Skip),
	_ => None,
	}
	} else if let Some(command) = trimmed.strip_prefix("yapf:") {
	match command.trim_whitespace_start() {
	"disable" => Some(SuppressionKind::Off),
	"enable" => Some(SuppressionKind::On),
	_ => None,
	}
	} else {
	None
	}
	}

Exclude pragma comments from measured line width #6772

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions