-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
internalAn internal refactor or improvementAn internal refactor or improvement
Description
This issue is part of #4181. The goal is to prepare the Fix and Edit API to ease adding the Applicability to Fix in a follow-up PR.
I propose the following changes to the API. Please feel free to deviate from or extend the proposal if I overlooked something.
Diagnostic:- Change
fixtoOption<Fix> - Change
set_fix,with_fixandtry_set_fixto accept aFix
- Change
Fix:- Rename
newtounspecified - Create the new
unspecified_edits(edit: Edit, rest: impl IntoIterator<Item = Edit>) -> Selffactory function - Change
unspecifiedtounspecified(edit: Edit) -> Self - Remove
is_empty(), - Remove the
FromIterator,From<Edit>andDefaultimplementations - Maybe: Add a
push_edit(&mut self, edit; Edit)method
- Rename
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
internalAn internal refactor or improvementAn internal refactor or improvement