-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
tyMulti-file analysis & type inferenceMulti-file analysis & type inference
Milestone
Description
This is a follow-up from #13671 that lists some tasks that were intentionally left out from #13980:
- Work on the
SymbolAPI: Functions likeas_type,unwrap_or,unwrap_or_neverignore possibly-unboundness. Look into call sites of those functions and see if that's really what we require in all cases. Possibly remove some of these functions. -
.unwrap_oris currently only used withType::Never. We did this to keep existing behavior for some cases where we then proceed to call.call(…), whereType::Neverwould lead to a "not callable" error, just likeType::Unboundbefore. This can be handled more explicitly, potentially with better diagnostics for the user. - Understand if we need to handle the possibly-unboundness of the
replacementargument inSymbol::replace_unbound_with. Write tests. - Investigate and understand the performance gains of [red-knot] remove Type::Unbound #13671.
- Possibly look into undeclared-ness issues brought up here. See also the corresponding TODO comment in
types.rs. => moved to Inconsistency between unbound and undeclared symbols ty#229 - Clarify if we want a diagnostic for in the situation described here => moved to Inconsistency between unbound and undeclared symbols ty#229
- Review the
Type::Unioncase in theType::member()function, potentially write some more tests
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
tyMulti-file analysis & type inferenceMulti-file analysis & type inference