Bump LibCST to 1.8.4 (#20321)

ntBre · web-flow · commit 9cb37db51017 · 2025-09-09T17:34:33.000-04:00
This should fix the fuzz build on `main`. They added support for t-strings, which made one of our matches non-exhaustive. https://github.com/Instagram/LibCST/releases/tag/v1.8.4
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -115,7 +115,7 @@ jiff = { version = "0.2.0" }
 js-sys = { version = "0.3.69" }
 jod-thread = { version = "1.0.0" }
 libc = { version = "0.2.153" }
-libcst = { version = "1.1.0", default-features = false }
+libcst = { version = "1.8.4", default-features = false }
 log = { version = "0.4.17" }
 lsp-server = { version = "0.7.6" }
 lsp-types = { git = "https://github.com/astral-sh/lsp-types.git", rev = "3512a9f", features = [
diff --git a/crates/ruff_linter/src/rules/pyupgrade/rules/format_literals.rs b/crates/ruff_linter/src/rules/pyupgrade/rules/format_literals.rs
@@ -164,7 +164,7 @@ fn remove_specifiers<'a>(value: &mut Expression<'a>, arena: &'a typed_arena::Are
                         stack.push(&mut string.left);
                         stack.push(&mut string.right);
                     }
-                    libcst_native::String::Formatted(_) => {}
+                    libcst_native::String::Formatted(_) | libcst_native::String::Templated(_) => {}
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ fn remove_specifiers<'a>(value: &mut Expression<'a>, arena: &'a typed_arena::Are`
`164`	`164`	`stack.push(&mut string.left);`
`165`	`165`	`stack.push(&mut string.right);`
`166`	`166`	`}`
`167`		`- libcst_native::String::Formatted(_) => {}`
	`167`	`+ libcst_native::String::Formatted(_) \| libcst_native::String::Templated(_) => {}`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`	`}`