[red-knot] Any cannot be parameterized (#14933)

AlexWaygood · web-flow · commit 45b565cbb5b2 · 2024-12-12T11:50:34.000Z
diff --git a/crates/red_knot_python_semantic/resources/mdtest/annotations/any.md b/crates/red_knot_python_semantic/resources/mdtest/annotations/any.md
@@ -69,3 +69,15 @@ y: int = Subclass()  # error: [invalid-assignment]
 def _(s: Subclass):
     reveal_type(s)  # revealed: Subclass
 ```
+
+## Invalid
+
+`Any` cannot be parameterized:
+
+```py
+from typing import Any
+
+# error: [invalid-type-parameter] "Type `typing.Any` expected no type parameter"
+def f(x: Any[int]):
+    reveal_type(x)  # revealed: Unknown
+```
diff --git a/crates/red_knot_python_semantic/src/types/infer.rs b/crates/red_knot_python_semantic/src/types/infer.rs
@@ -4863,7 +4863,17 @@ impl<'db> TypeInferenceBuilder<'db> {
             }
             KnownInstanceType::Type => self.infer_subclass_of_type_expression(parameters),
             KnownInstanceType::Tuple => self.infer_tuple_type_expression(parameters),
-            KnownInstanceType::Any => Type::Any,
+            KnownInstanceType::Any => {
+                self.diagnostics.add_lint(
+                    &INVALID_TYPE_PARAMETER,
+                    subscript.into(),
+                    format_args!(
+                        "Type `{}` expected no type parameter",
+                        known_instance.repr(self.db)
+                    ),
+                );
+                Type::Unknown
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -4863,7 +4863,17 @@ impl<'db> TypeInferenceBuilder<'db> {`
`4863`	`4863`	`}`
`4864`	`4864`	`KnownInstanceType::Type => self.infer_subclass_of_type_expression(parameters),`
`4865`	`4865`	`KnownInstanceType::Tuple => self.infer_tuple_type_expression(parameters),`
`4866`		`- KnownInstanceType::Any => Type::Any,`
	`4866`	`+ KnownInstanceType::Any => {`
	`4867`	`+ self.diagnostics.add_lint(`
	`4868`	`+ &INVALID_TYPE_PARAMETER,`
	`4869`	`+ subscript.into(),`
	`4870`	`+ format_args!(`
	`4871`	+ "Type `{}` expected no type parameter",
	`4872`	`+ known_instance.repr(self.db)`
	`4873`	`+ ),`
	`4874`	`+ );`
	`4875`	`+ Type::Unknown`
	`4876`	`+ }`
`4867`	`4877`	`}`
`4868`	`4878`	`}`
`4869`	`4879`