Repository navigation
Commit 3433449
authored
[ty] Reuse full call diagnostics for implicit setter calls (#27115)
## Summary
Reuse the full call-error diagnostic machinery for implicit descriptor
`__set__` and custom `__setattr__` calls. The call reporter can override
the main lint/message, retain the original call failure on the primary
annotation, map synthesized arguments back to their source ranges, and
add an info diagnostic explaining why the method was called.
This PR also correctly re-classifies failed `__setattr__` assignments as
`invalid-assignment` instead of `unresolved-attribute`.
This PR currently only applies this system to `__set__` and
`__setattr__` calls, but it can be extended to any diagnostic resulting
from a failed implicit dunder call.
Closes astral-sh/ty#4034
## Test plan
Added and updated mdtests covering invalid descriptor values, malformed
`__set__` signatures, concise expected/found output, nested tuple
incompatibilities, overloaded `__setattr__`, invalid attribute names and
values reported together, and instance/metaclass `__setattr__`
assignments.1 parent 2240070 commit 3433449
9 files changed
Lines changed: 543 additions & 133 deletions
File tree
- crates/ty_python_semantic
- resources/mdtest
- diagnostics
- src/types
- call
- infer/builder
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2980 | 2980 | | |
2981 | 2981 | | |
2982 | 2982 | | |
| 2983 | + | |
| 2984 | + | |
| 2985 | + | |
| 2986 | + | |
| 2987 | + | |
| 2988 | + | |
| 2989 | + | |
| 2990 | + | |
| 2991 | + | |
| 2992 | + | |
| 2993 | + | |
| 2994 | + | |
| 2995 | + | |
| 2996 | + | |
| 2997 | + | |
| 2998 | + | |
| 2999 | + | |
| 3000 | + | |
| 3001 | + | |
| 3002 | + | |
| 3003 | + | |
| 3004 | + | |
| 3005 | + | |
| 3006 | + | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
| 3027 | + | |
| 3028 | + | |
| 3029 | + | |
| 3030 | + | |
| 3031 | + | |
| 3032 | + | |
| 3033 | + | |
| 3034 | + | |
| 3035 | + | |
| 3036 | + | |
| 3037 | + | |
| 3038 | + | |
| 3039 | + | |
| 3040 | + | |
| 3041 | + | |
| 3042 | + | |
| 3043 | + | |
| 3044 | + | |
| 3045 | + | |
| 3046 | + | |
| 3047 | + | |
| 3048 | + | |
| 3049 | + | |
| 3050 | + | |
| 3051 | + | |
2983 | 3052 | | |
2984 | 3053 | | |
2985 | 3054 | | |
| |||
2998 | 3067 | | |
2999 | 3068 | | |
3000 | 3069 | | |
3001 | | - | |
| 3070 | + | |
| 3071 | + | |
| 3072 | + | |
3002 | 3073 | | |
3003 | 3074 | | |
3004 | 3075 | | |
| 3076 | + | |
| 3077 | + | |
| 3078 | + | |
| 3079 | + | |
| 3080 | + | |
| 3081 | + | |
| 3082 | + | |
| 3083 | + | |
| 3084 | + | |
| 3085 | + | |
| 3086 | + | |
| 3087 | + | |
| 3088 | + | |
| 3089 | + | |
| 3090 | + | |
| 3091 | + | |
| 3092 | + | |
| 3093 | + | |
| 3094 | + | |
| 3095 | + | |
| 3096 | + | |
| 3097 | + | |
| 3098 | + | |
| 3099 | + | |
| 3100 | + | |
| 3101 | + | |
| 3102 | + | |
| 3103 | + | |
| 3104 | + | |
| 3105 | + | |
| 3106 | + | |
| 3107 | + | |
| 3108 | + | |
| 3109 | + | |
| 3110 | + | |
| 3111 | + | |
| 3112 | + | |
| 3113 | + | |
| 3114 | + | |
| 3115 | + | |
| 3116 | + | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
| 3121 | + | |
3005 | 3122 | | |
3006 | 3123 | | |
3007 | 3124 | | |
| |||
3117 | 3234 | | |
3118 | 3235 | | |
3119 | 3236 | | |
3120 | | - | |
| 3237 | + | |
3121 | 3238 | | |
3122 | 3239 | | |
3123 | 3240 | | |
| |||
3158 | 3275 | | |
3159 | 3276 | | |
3160 | 3277 | | |
3161 | | - | |
| 3278 | + | |
3162 | 3279 | | |
3163 | 3280 | | |
3164 | 3281 | | |
| |||
3169 | 3286 | | |
3170 | 3287 | | |
3171 | 3288 | | |
3172 | | - | |
| 3289 | + | |
3173 | 3290 | | |
3174 | 3291 | | |
3175 | 3292 | | |
3176 | | - | |
| 3293 | + | |
3177 | 3294 | | |
3178 | 3295 | | |
3179 | 3296 | | |
3180 | 3297 | | |
3181 | 3298 | | |
3182 | 3299 | | |
3183 | 3300 | | |
3184 | | - | |
| 3301 | + | |
3185 | 3302 | | |
3186 | 3303 | | |
3187 | 3304 | | |
| |||
3225 | 3342 | | |
3226 | 3343 | | |
3227 | 3344 | | |
3228 | | - | |
| 3345 | + | |
3229 | 3346 | | |
3230 | 3347 | | |
3231 | 3348 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
| 218 | + | |
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| |||
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
483 | | - | |
| 483 | + | |
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
| |||
586 | 586 | | |
587 | 587 | | |
588 | 588 | | |
589 | | - | |
| 589 | + | |
590 | 590 | | |
591 | 591 | | |
592 | 592 | | |
| |||
735 | 735 | | |
736 | 736 | | |
737 | 737 | | |
738 | | - | |
| 738 | + | |
739 | 739 | | |
740 | 740 | | |
741 | 741 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
277 | | - | |
278 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
279 | 282 | | |
280 | 283 | | |
281 | 284 | | |
282 | | - | |
283 | | - | |
| 285 | + | |
| 286 | + | |
284 | 287 | | |
285 | | - | |
286 | | - | |
| 288 | + | |
| 289 | + | |
287 | 290 | | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
288 | 298 | | |
289 | 299 | | |
290 | 300 | | |
| |||
299 | 309 | | |
300 | 310 | | |
301 | 311 | | |
302 | | - | |
303 | 312 | | |
304 | 313 | | |
305 | 314 | | |
306 | 315 | | |
307 | | - | |
308 | | - | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
309 | 354 | | |
310 | | - | |
311 | | - | |
| 355 | + | |
| 356 | + | |
312 | 357 | | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
313 | 395 | | |
314 | 396 | | |
315 | 397 | | |
| |||
0 commit comments