Fix all cargo shear warnings (#24268)

MichaReiser · web-flow · commit 2d6ce561250a · 2026-03-29T13:57:30.000+01:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -732,7 +732,7 @@ jobs:
           persist-credentials: false
       - uses: cargo-bins/cargo-binstall@1800853f2578f8c34492ec76154caef8e163fbca # v1.17.7
       - run: cargo binstall --no-confirm cargo-shear
-      - run: cargo shear
+      - run: cargo shear --deny-warnings
 
   ty-completion-evaluation:
     name: "ty completion evaluation"
diff --git a/Cargo.toml b/Cargo.toml
@@ -216,9 +216,6 @@ zip = { version = "0.6.6", default-features = false }
 [workspace.metadata.cargo-shear]
 ignored = [
     "getrandom",
-    "ruff_options_metadata",
-    "uuid",
-    "get-size2",
     "ty_completion_bench",
     "ty_completion_eval",
 ]
diff --git a/crates/ruff/Cargo.toml b/crates/ruff/Cargo.toml
@@ -93,3 +93,6 @@ test-case = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ruff_annotate_snippets/Cargo.toml b/crates/ruff_annotate_snippets/Cargo.toml
@@ -10,8 +10,6 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = "MIT OR Apache-2.0"
 
-[lib]
-
 [dependencies]
 anstyle = { workspace = true }
 memchr = { workspace = true }
@@ -36,3 +34,6 @@ harness = false
 
 [lints]
 workspace = true
+
+[lib]
+test = false
diff --git a/crates/ruff_benchmark/Cargo.toml b/crates/ruff_benchmark/Cargo.toml
@@ -93,3 +93,17 @@ required-features = ["ty_walltime"]
 
 [lints]
 workspace = true
+
+[package.metadata.cargo-shear]
+# We use optional dependencies even for dev dependencies for faster CI compile times.
+# This is fine because this crate is "dev-only".
+ignored = [
+    "divan",
+    "ruff_linter",
+    "ruff_python_formatter",
+    "ruff_python_parser",
+    "ruff_python_trivia",
+    "ty-project",
+    "mimalloc",
+    "tikv-jemallocator"
+]
diff --git a/crates/ruff_cache/Cargo.toml b/crates/ruff_cache/Cargo.toml
@@ -23,3 +23,6 @@ ruff_macros = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+test = false
diff --git a/crates/ruff_diagnostics/Cargo.toml b/crates/ruff_diagnostics/Cargo.toml
@@ -12,6 +12,7 @@ license = { workspace = true }
 
 [lib]
 doctest = false
+test = false
 
 [dependencies]
 ruff_text_size = { workspace = true, features = ["get-size"] }
diff --git a/crates/ruff_graph/Cargo.toml b/crates/ruff_graph/Cargo.toml
@@ -33,3 +33,7 @@ zip = { workspace = true, features = [] }
 
 [lints]
 workspace = true
+
+[lib]
+test = false
+doctest = false
diff --git a/crates/ruff_macros/Cargo.toml b/crates/ruff_macros/Cargo.toml
@@ -13,6 +13,7 @@ license = { workspace = true }
 [lib]
 proc-macro = true
 doctest = false
+test = false
 
 [dependencies]
 ruff_python_trivia = { workspace = true }
diff --git a/crates/ruff_markdown/Cargo.toml b/crates/ruff_markdown/Cargo.toml
@@ -26,3 +26,6 @@ insta = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ruff_memory_usage/Cargo.toml b/crates/ruff_memory_usage/Cargo.toml
@@ -15,3 +15,7 @@ get-size2 = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+test = false
+doctest = false
diff --git a/crates/ruff_notebook/Cargo.toml b/crates/ruff_notebook/Cargo.toml
@@ -10,9 +10,6 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
-[lib]
-doctest = false
-
 [dependencies]
 ruff_diagnostics = { workspace = true }
 ruff_source_file = { workspace = true, features = ["serde"] }
diff --git a/crates/ruff_options_metadata/Cargo.toml b/crates/ruff_options_metadata/Cargo.toml
@@ -13,7 +13,8 @@ license = { workspace = true }
 [dependencies]
 serde = { workspace = true, optional = true }
 
-[dev-dependencies]
-
 [lints]
 workspace = true
+
+[lib]
+test = false
diff --git a/crates/ruff_python_ast_integration_tests/Cargo.toml b/crates/ruff_python_ast_integration_tests/Cargo.toml
@@ -9,8 +9,6 @@ repository.workspace = true
 authors.workspace = true
 license.workspace = true
 
-[dependencies]
-
 [dev-dependencies]
 ruff_python_ast = { workspace = true }
 ruff_python_parser = { workspace = true }
@@ -21,3 +19,7 @@ insta = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+test = false
+doctest = false
diff --git a/crates/ruff_python_importer/Cargo.toml b/crates/ruff_python_importer/Cargo.toml
@@ -29,3 +29,6 @@ insta = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ruff_python_semantic/Cargo.toml b/crates/ruff_python_semantic/Cargo.toml
@@ -37,3 +37,6 @@ test-case = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ruff_python_trivia_integration_tests/Cargo.toml b/crates/ruff_python_trivia_integration_tests/Cargo.toml
@@ -9,8 +9,6 @@ repository.workspace = true
 authors.workspace = true
 license.workspace = true
 
-[dependencies]
-
 [dev-dependencies]
 ruff_python_parser = { workspace = true }
 ruff_python_trivia = { workspace = true }
@@ -20,3 +18,7 @@ insta = { workspace = true }
 
 [lints]
 workspace = true
+
+[lib]
+test = false
+doctest = false
diff --git a/crates/ruff_server/Cargo.toml b/crates/ruff_server/Cargo.toml
@@ -10,8 +10,6 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
-[lib]
-
 [dependencies]
 ruff_db = { workspace = true }
 ruff_diagnostics = { workspace = true }
@@ -56,3 +54,6 @@ test-uv = []
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ruff_text_size/Cargo.toml b/crates/ruff_text_size/Cargo.toml
@@ -30,3 +30,6 @@ workspace = true
 name = "serde"
 path = "tests/serde.rs"
 required-features = ["serde"]
+
+[lib]
+test = false
diff --git a/crates/ruff_wasm/Cargo.toml b/crates/ruff_wasm/Cargo.toml
@@ -14,6 +14,7 @@ description = "WebAssembly bindings for Ruff"
 [lib]
 crate-type = ["cdylib", "rlib"]
 doctest = false
+test = false
 
 [dependencies]
 ruff_formatter = { workspace = true }
@@ -49,3 +50,8 @@ default = ["console_error_panic_hook"]
 
 [lints]
 workspace = true
+
+[package.metadata.cargo-shear]
+ignored = [
+    "uuid",
+]
diff --git a/crates/ty/Cargo.toml b/crates/ty/Cargo.toml
@@ -13,6 +13,9 @@ license.workspace = true
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
+[lib]
+doctest = false
+
 [dependencies]
 ruff_db = { workspace = true, features = ["os", "cache", "junit"] }
 ruff_python_ast = { workspace = true }
diff --git a/crates/ty_combine/Cargo.toml b/crates/ty_combine/Cargo.toml
@@ -9,6 +9,9 @@ repository.workspace = true
 authors.workspace = true
 license.workspace = true
 
+[lib]
+doctest = false
+
 [dependencies]
 ruff_db = { workspace = true }
 ruff_python_ast = { workspace = true }
diff --git a/crates/ty_ide/Cargo.toml b/crates/ty_ide/Cargo.toml
@@ -10,6 +10,9 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
+[lib]
+doctest = false
+
 [dependencies]
 bitflags = { workspace = true }
 ruff_db = { workspace = true }
diff --git a/crates/ty_project/Cargo.toml b/crates/ty_project/Cargo.toml
@@ -10,6 +10,9 @@ authors.workspace = true
 license.workspace = true
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+#
+[lib]
+doctest = false
 
 [dependencies]
 ruff_cache = { workspace = true }
diff --git a/crates/ty_server/Cargo.toml b/crates/ty_server/Cargo.toml
@@ -10,6 +10,9 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
+[lib]
+doctest = false
+
 [dependencies]
 ruff_db = { workspace = true, features = ["os"] }
 ruff_diagnostics = { workspace = true }
diff --git a/crates/ty_site_packages/Cargo.toml b/crates/ty_site_packages/Cargo.toml
@@ -10,6 +10,9 @@ documentation = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
+[lib]
+doctest = false
+
 [dependencies]
 ruff_annotate_snippets = { workspace = true }
 ruff_db = { workspace = true }
diff --git a/crates/ty_static/Cargo.toml b/crates/ty_static/Cargo.toml
@@ -11,6 +11,7 @@ license = { workspace = true }
 
 [lib]
 doctest = false
+test = false
 
 [dependencies]
 ruff_macros = { workspace = true }
diff --git a/crates/ty_test/Cargo.toml b/crates/ty_test/Cargo.toml
@@ -10,6 +10,9 @@ repository.workspace = true
 authors.workspace = true
 license.workspace = true
 
+[lib]
+doctest = false
+
 [dependencies]
 ruff_db = { workspace = true, features = ["os", "testing"] }
 ruff_diagnostics = { workspace = true }
diff --git a/crates/ty_vendored/Cargo.toml b/crates/ty_vendored/Cargo.toml
@@ -29,3 +29,6 @@ deflate = ["zip/deflate"]
 
 [lints]
 workspace = true
+
+[lib]
+doctest = false
diff --git a/crates/ty_wasm/Cargo.toml b/crates/ty_wasm/Cargo.toml
@@ -12,12 +12,17 @@ license = { workspace = true }
 description = "WebAssembly bindings for ty"
 
 [package.metadata.cargo-shear]
-# Depended on only to enable `log` feature as of 2025-10-03.
-ignored = ["tracing"]
+ignored = [
+    # Depended on only to enable `log` feature as of 2025-10-03.
+    "tracing",
+
+    "uuid",
+]
 
 [lib]
 crate-type = ["cdylib", "rlib"]
 doctest = false
+test = false
 
 [dependencies]
 ty_ide = { workspace = true }
