Proper parsing of next attribute after valueless#13
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Nov 17, 2025
Merged
Proper parsing of next attribute after valueless#13charliermarsh merged 3 commits intoastral-sh:mainfrom
charliermarsh merged 3 commits intoastral-sh:mainfrom
Conversation
Fix y21#70 Step back one position when encountering a valueless attribute so the parser can advance and parse the following attribute correctly.
charliermarsh
approved these changes
Nov 17, 2025
charliermarsh
added a commit
that referenced
this pull request
Dec 6, 2025
## Summary I don't know if this is the root cause of astral-sh/uv#16937, but it does appear to be a loop introduced in #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix y21#70
Step back one position when encountering a valueless attribute so the parser can advance and parse the following attribute correctly.