Skip to content

Create subscriptions with all-notification#9

Merged
ruKurz merged 2 commits intomasterfrom
hotfix/#7-request-notification
Sep 19, 2017
Merged

Create subscriptions with all-notification#9
ruKurz merged 2 commits intomasterfrom
hotfix/#7-request-notification

Conversation

@mrsimpson
Copy link
Copy Markdown
Member

...for email, mobile and Desktop on creation of a request

This fix leads to the following state of a created request:
subscription-notifications

@ruKurz please test and merge using squash

@mrsimpson mrsimpson self-assigned this Sep 19, 2017
@mrsimpson mrsimpson requested a review from ruKurz September 19, 2017 07:29
@ruKurz ruKurz merged commit 13e9849 into master Sep 19, 2017
@ruKurz
Copy link
Copy Markdown

ruKurz commented Sep 19, 2017

Seems to be straight forward.

Maybe one could generalize / externalize the local function createNotifications to

/**
 * This method activates the given channels for username and room.
 *
 * By passing an empty array as channels the notification is turned off.
 *
 * @param usernames - the users to notify 
 * @param roomId - the id of the room the users should be notified about
 * @param channels - channels (desktop, mobile, email) to activate for notification
 */
createNotifications = function(usernames, roomId, channels[]);

@mrsimpson
Copy link
Copy Markdown
Member Author

fixed #7

@mrsimpson mrsimpson deleted the hotfix/#7-request-notification branch December 7, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants