Use encodeURI in AmazonS3 contentDisposition file.name to prevent fail#201
Merged
Use encodeURI in AmazonS3 contentDisposition file.name to prevent fail#201
Conversation
Adds: - encodeURI in AmazonS3 store to allow special chars in file name;
ghost
assigned
Member
Author
|
This fix has been cherry-picked from 798d626 which has already been merged by Rocket.Chat into 0.60. Thus, I consider this integration-tested @ThomasRoehl It's a bit tricky to validate the fix without having S3-running, but still wanted to ask you to have a look at it whether there's something coming to your mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the upload to S3 failing with special characters in filenames (such as German Umlaute, ä, ö, ü).
Cheery-picked a fix from 0.60