Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't detect pk in some DBMS #31

Closed
deffence1776 opened this issue Dec 26, 2015 · 3 comments
Closed

can't detect pk in some DBMS #31

deffence1776 opened this issue Dec 26, 2015 · 3 comments
Labels
bug

Comments

@deffence1776
Copy link

In some DBMS, DatabaseMetaData#getPrimaryKeys returns COLUMN_NAME in lowercase.
(I tried sqlite3)

I think you should add String#toUpperCase when you get primarykey's column name at org.assertj.db.type.Table#collectPrimaryKeyName

     while (resultSet.next()) {
        String columnName = resultSet.getString("COLUMN_NAME").toUpperCase();
        if (getColumnsNameList().indexOf(columnName) != -1) {
          pksNameList.add(columnName);
        }
      }

Thank you.
@tnazare tnazare mentioned this issue Feb 23, 2016
Closed
@tnazare
Copy link

tnazare commented Feb 23, 2016

#33

@regis1512 regis1512 added the bug label Mar 12, 2016
@regis1512
Copy link
Member

Sorry to have be long to implement a solution.
You can now find new classes : LetterCase and all associated classes (especially SourceWithLetterCase and DataSourceWithLetterCase) which are here to fix this problem.

When you instantiate a SourceWithLetterCase or DataSourceWithLetterCase, you can indicate the behavior (the conversion like upper and lower and the comparison) with the letter case of the tables, columns and primary keys.
I hope that with this flexibility that all the users can find a compatible solution with their database.
Please note that the solution is extensible because LetterCase use CaseComparison and CaseConversion which are interfaces.

@regis1512
Copy link
Member

And thank to tnazare for his proposition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tnazare @regis1512 @deffence1776