Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert#2969
Closed
0x1306e6d wants to merge 4 commits intoassertj:mainfrom
Closed
Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert#29690x1306e6d wants to merge 4 commits intoassertj:mainfrom
hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert#29690x1306e6d wants to merge 4 commits intoassertj:mainfrom
Conversation
joel-costigliola
requested changes
Mar 2, 2023
Member
joel-costigliola
left a comment
joel-costigliola
left a comment
There was a problem hiding this comment.
Thanks @ghkim3221, first round of code review done.
| import static org.assertj.core.api.Assertions.assertThatExceptionOfType; | ||
| import static org.assertj.core.error.ShouldNotContainValue.shouldNotContainValue; | ||
|
|
||
| class AtomicReferenceAssert_doesNotHaveNullValue_Test { |
Member
There was a problem hiding this comment.
Can you follow the testing guidelines documented in https://github.com/assertj/assertj/blob/main/CONTRIBUTING.md notably using GIVEN WHEN THEN and AssertionUtil.expectAssertionError.
this comment applies to the other test too, thanks!
Member
|
Integrated thanks @ghkim3221! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.
hasNullValueanddoesNotHaveNullValuewill be useful for checking whether anAtomicReferencehas the null value or not. These are shortcuts ofhasVallue(null)anddoesNotHaveValue(null)and would be useful when using package which non-null is the default since IDE may warn thathasVallue(null)receivesnull.