Add isInThePast and isInTheFuture to LocalDate assertions#2933
Closed
StefanBratanov wants to merge 2 commits intoassertj:mainfrom
Closed
Add isInThePast and isInTheFuture to LocalDate assertions#2933StefanBratanov wants to merge 2 commits intoassertj:mainfrom
isInThePast and isInTheFuture to LocalDate assertions#2933StefanBratanov wants to merge 2 commits intoassertj:mainfrom
Conversation
StefanBratanov
force-pushed
the
is_in_the_past_future_local_date
branch
from
9621323 to
04c6ea4
Compare
Member
|
Integrated thanks @StefanBratanov for the good work!
|
Contributor
Author
Thank you @joel-costigliola . Will keep in mind for any future contributions. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
isPast()andisFuture()methods for asserting dates #2932Two things I am unsure about:
@sinceversionShouldBeInTheFuture/ThePasterror message contains the class name (java.time.LocalDate). This seems to be the behaviour of theMessageFormatterhandling dates classes. Is the error message ok like this?