Skip to content

Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions#2580

Closed
hezean wants to merge 1 commit intoassertj:mainfrom
hezean:main
Closed

Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions#2580
hezean wants to merge 1 commit intoassertj:mainfrom
hezean:main

Conversation

@hezean
Copy link
Copy Markdown
Contributor

@hezean hezean commented Apr 19, 2022

As #2509 (comment) mentioned, several methods are added as the shortcuts for extracting boolean and numbers.

Check List:

@hezean
Copy link
Copy Markdown
Contributor Author

hezean commented Apr 20, 2022

Hi @scordio, sorry for bothering. This PR implements the methods you mentioned, could you please review the code?

@scordio
Copy link
Copy Markdown
Member

scordio commented Apr 21, 2022

Hi @hezean, thanks for the PR.

Despite my proposal at #2509 (comment), we haven't discussed these new methods in the team yet, so it may take some time before we move on to the review phase.

Thanks in advance for your patience!

@scordio scordio mentioned this pull request Apr 21, 2022
Closed
@hezean
Copy link
Copy Markdown
Contributor Author

hezean commented Jan 18, 2023 •
edited
Loading

Hi @scordio, it seems that 3.24.2 is already released. Any update on the methods related in this pr?

Tentatively slated for 3.24.0 solely for the purpose of team discussion
in #2520 (comment)

@scordio
Copy link
Copy Markdown
Member

scordio commented Jan 20, 2023

Hi @hezean , thanks again for your patience. I'll make sure this gets covered for 3.25.0.

@scordio scordio added this to the 3.25.0 milestone Jan 20, 2023
@scordio scordio self-assigned this Jan 20, 2023
@joel-costigliola joel-costigliola self-assigned this Feb 6, 2023
@scordio scordio removed their assignment Feb 7, 2023
joel-costigliola
joel-costigliola reviewed Mar 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hezean, first round of code review done. Sorry for the long wait!

Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/main/java/org/assertj/core/api/AbstractStringAssert.java Outdated
Comment thread assertj-core/src/test/java/org/assertj/core/api/string_/StringAssert_asBoolean_Test.java Outdated
Comment thread assertj-core/src/test/java/org/assertj/core/api/string_/StringAssert_asBoolean_Test.java Outdated
Comment thread assertj-core/src/test/java/org/assertj/core/api/string_/StringAssert_asByte_Test.java
@hezean
Copy link
Copy Markdown
Contributor Author

hezean commented Mar 7, 2023

Hi @joel-costigliola, I really appreciate for your review, and thanks for giving me an opportunity to contribute to assertj!

I've just cleaned up this PR, fixing all the issues you pointed out. Please let me know if anything should be made better.

@hezean hezean requested a review from joel-costigliola March 9, 2023 03:52
@joel-costigliola
Copy link
Copy Markdown
Member

joel-costigliola commented Mar 9, 2023

Integrated thanks @hezean! I did some minor cleanup and added support for soft assertions which is a bit tricky to do if you are not familiar with how they work, you can look at the commit if you are interested, anyway you get full credit for the changes 😉

@scordio scordio mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joel-costigliola joel-costigliola Awaiting requested review from joel-costigliola

Assignees

@joel-costigliola joel-costigliola

Labels

None yet

Projects

None yet

Milestone

3.25.0

Development

Successfully merging this pull request may close these issues.

Add (Abstract)StringAssert#as(Boolean|Byte|Short|Integer|Long|Float|Double)

3 participants

@hezean @scordio @joel-costigliola