Change precedence of assumption classes#1983
Merged
joel-costigliola merged 1 commit intoassertj:mainfrom Aug 28, 2020
scordio:fix-testng-assumptions
Merged
Change precedence of assumption classes#1983joel-costigliola merged 1 commit intoassertj:mainfrom scordio:fix-testng-assumptions
joel-costigliola merged 1 commit intoassertj:mainfrom
scordio:fix-testng-assumptions
Conversation
Member
joel-costigliola
left a comment
joel-costigliola
left a comment
There was a problem hiding this comment.
thanks @scordio, looks good, just some minor comments
src/test/java/org/assertj/core/api/assumptions/Assumptions_assumeThat_Atomics_Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/assertj/core/api/assumptions/Assumptions_assumeThat_Atomics_Test.java
Outdated
Show resolved
Hide resolved
In order of priority: * org.opentest4j.TestAbortedException * org.testng.SkipException * org.junit.AssumptionViolatedException
Member
Author
|
@joel-costigliola PR ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to testng-team/testng#2352.
Check List: