-
-
Notifications
You must be signed in to change notification settings - Fork 772
Comparing changes
Open a pull request
base repository: assertj/assertj
base: assertj-core-3.17.1
head repository: assertj/assertj
compare: assertj-core-3.17.2
- 10 commits
- 13 files changed
- 4 contributors
Commits on Aug 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bc5f612 - Browse repository at this point
Copy the full SHA bc5f612View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dec889 - Browse repository at this point
Copy the full SHA 7dec889View commit details
Commits on Sep 3, 2020
-
Add OSGi integration testing to build (#1888)
We define a simple test class to verify basic operations. Fixes #1888 Signed-off-by: BJ Hargrave <[email protected]>
2Configuration menu - View commit details
-
Copy full SHA for c9807b9 - Browse repository at this point
Copy the full SHA c9807b9View commit details -
The use of timestamps to replace SNAPSHOT is an old oddity of
bnd-maven-plugin. So we use `-snapshot: SNAPSHOT` to correct this. We also use `-noextraheaders: true` to remove headers which can break reproducible builds. This elides `Bnd-LastModified` so we can remove it from `-removeheaders`. See https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#reproducible-builds Signed-off-by: BJ Hargrave <[email protected]> Handle soft proxies for custom assert classes in OSGi bundles (#1979) When using a composite class loader for defining soft proxies when the assert class is from a different class loader than the AssertJ classes, we now use the composite class loader as the ClassLoadingStrategy for ByteBuddy. This is necessary for Java 9+ to avoid the ClassLoadingStrategy.UsingLookup default strategy used by AssertJ for Java 9+. That strategy always defines the proxy classes in the class loader defining the assert class ignoring the specified class loader. This change is also beneficial for Java 8 as it avoids the need to reflectively call the composite class loader to define the proxy classes. We refactor the CompositeClassLoader into the ClassLoadingStrategyFactory class so that we can centralize the logic for class loader and class loading strategy determination. Assumptions is updated to use these changes which prepares it for a future where it could support defining custom assumptions. Finally, we update the class loader used for the ByteBuddy class caches to use the class loader of the assert class rather than AssertJ's class loader as the key. This is important in the OSGi case where multiple bundles could define custom assertions with the same class name and we must allow for unique proxy class generation for each bundle. Fixes #1979 Signed-off-by: BJ Hargrave <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fb09d9 - Browse repository at this point
Copy the full SHA 7fb09d9View commit details
Commits on Sep 4, 2020
-
Exclude net.bytebuddy.experimental from shading scope
This ensures that ByteBuddy experimental features can be enabled setting the 'net.bytebuddy.experimental' property also when AssertJ is used as a dependency of other applications.
Configuration menu - View commit details
-
Copy full SHA for 3a9ca44 - Browse repository at this point
Copy the full SHA 3a9ca44View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d9c05 - Browse repository at this point
Copy the full SHA c2d9c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79a5142 - Browse repository at this point
Copy the full SHA 79a5142View commit details -
Add soft assertions wasSuccess tests
Separate them from other soft assertions tests
Configuration menu - View commit details
-
Copy full SHA for 91db723 - Browse repository at this point
Copy the full SHA 91db723View commit details
Commits on Sep 5, 2020
-
Demote opentest4j between assumption exception classes (fixes #1985)
New order of priority: * org.testng.SkipException * org.junit.AssumptionViolatedException * org.opentest4j.TestAbortedException
Configuration menu - View commit details
-
Copy full SHA for cf65f6a - Browse repository at this point
Copy the full SHA cf65f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f654ef - Browse repository at this point
Copy the full SHA 3f654efView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff assertj-core-3.17.1...assertj-core-3.17.2