Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: assertj/assertj
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: assertj-core-3.17.1
Choose a base ref
...
head repository: assertj/assertj
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: assertj-core-3.17.2
Choose a head ref
  • 10 commits
  • 13 files changed
  • 4 contributors

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    bc5f612 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dec889 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add OSGi integration testing to build (#1888)

    We define a simple test class to verify basic operations.
    
    Fixes #1888
    
    Signed-off-by: BJ Hargrave <[email protected]>
    bjhargrave authored and joel-costigliola committed Sep 3, 2020
    2 Configuration menu
    Copy the full SHA
    c9807b9 View commit details
    Browse the repository at this point in the history
  2. The use of timestamps to replace SNAPSHOT is an old oddity of

    bnd-maven-plugin. So we use `-snapshot: SNAPSHOT` to correct this.
    
    We also use `-noextraheaders: true` to remove headers which can break
    reproducible builds. This elides `Bnd-LastModified` so we can remove it
    from `-removeheaders`.
    
    See https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#reproducible-builds
    
    Signed-off-by: BJ Hargrave <[email protected]>
    Handle soft proxies for custom assert classes in OSGi bundles (#1979)
    
    When using a composite class loader for defining soft proxies when the
    assert class is from a different class loader than the AssertJ classes,
    we now use the composite class loader as the ClassLoadingStrategy for
    ByteBuddy. This is necessary for Java 9+ to avoid the
    ClassLoadingStrategy.UsingLookup default strategy used by AssertJ for
    Java 9+. That strategy always defines the proxy classes in the class
    loader defining the assert class ignoring the specified class loader.
    This change is also beneficial for Java 8 as it avoids the need to
    reflectively call the composite class loader to define the proxy
    classes.
    
    We refactor the CompositeClassLoader into the
    ClassLoadingStrategyFactory class so that we can centralize the logic
    for class loader and class loading strategy determination. Assumptions
    is updated to use these changes which prepares it for a future where it
    could support defining custom assumptions.
    
    Finally, we update the class loader used for the ByteBuddy class caches
    to use the class loader of the assert class rather than AssertJ's class
    loader as the key. This is important in the OSGi case where multiple
    bundles could define custom assertions with the same class name and we
    must allow for unique proxy class generation for each bundle.
    
    Fixes #1979
    
    Signed-off-by: BJ Hargrave <[email protected]>
    bjhargrave authored and joel-costigliola committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7fb09d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Exclude net.bytebuddy.experimental from shading scope

    This ensures that ByteBuddy experimental features can be enabled setting
    the 'net.bytebuddy.experimental' property also when AssertJ is used as
    a dependency of other applications.
    scordio committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    3a9ca44 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2d9c05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79a5142 View commit details
    Browse the repository at this point in the history
  4. Add soft assertions wasSuccess tests

    Separate them from other soft assertions tests
    joel-costigliola committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    91db723 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Demote opentest4j between assumption exception classes (fixes #1985)

    New order of priority:
    * org.testng.SkipException
    * org.junit.AssumptionViolatedException
    * org.opentest4j.TestAbortedException
    scordio committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    cf65f6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f654ef View commit details
    Browse the repository at this point in the history
Loading