RecursiveComparisonConfiguration.Builder: set the standard representation if not was specified

joel-costigliola · joel-costigliola · commit 8030727c20a8 · 2025-01-01T16:59:05.000+01:00
Fix #3719
diff --git a/assertj-core/src/main/java/org/assertj/core/api/recursive/comparison/RecursiveComparisonConfiguration.java b/assertj-core/src/main/java/org/assertj/core/api/recursive/comparison/RecursiveComparisonConfiguration.java
@@ -22,6 +22,7 @@
 import static org.assertj.core.data.MapEntry.entry;
 import static org.assertj.core.internal.RecursiveHelper.isContainer;
 import static org.assertj.core.internal.TypeComparators.defaultTypeComparators;
+import static org.assertj.core.presentation.StandardRepresentation.STANDARD_REPRESENTATION;
 import static org.assertj.core.util.Lists.list;
 import static org.assertj.core.util.Sets.newLinkedHashSet;
 
@@ -116,7 +117,7 @@ private RecursiveComparisonConfiguration(Builder builder) {
     this.fieldMessages = builder.fieldMessages;
     this.typeMessages = builder.typeMessages;
     this.introspectionStrategy = builder.introspectionStrategy;
-    this.representation = builder.representation;
+    this.representation = builder.representation != null ? builder.representation : STANDARD_REPRESENTATION;
   }
 
   public RecursiveComparisonConfiguration(Representation representation) {
diff --git a/assertj-tests/assertj-integration-tests/assertj-core-tests/src/test/java/org/assertj/tests/core/api/recursive/comparison/RecursiveComparisonConfiguration_builder_Test.java b/assertj-tests/assertj-integration-tests/assertj-core-tests/src/test/java/org/assertj/tests/core/api/recursive/comparison/RecursiveComparisonConfiguration_builder_Test.java
@@ -14,6 +14,7 @@
 
 import static org.assertj.core.api.Assertions.catchThrowable;
 import static org.assertj.core.api.BDDAssertions.then;
+import static org.assertj.core.presentation.StandardRepresentation.STANDARD_REPRESENTATION;
 import static org.assertj.tests.core.testkit.AlwaysEqualComparator.alwaysEqual;
 import static org.assertj.tests.core.testkit.BiPredicates.STRING_EQUALS;
 
@@ -378,6 +379,14 @@ public Object getChildNodeValue(String childNodeName, Object instance) {
     then(configuration.getIntrospectionStrategy()).isSameAs(myIntrospectionStrategy);
   }
 
+  @Test
+  void should_set_the_standard_representation_if_none_is_set() {
+    // WHEN
+    RecursiveComparisonConfiguration recursiveComparisonConfiguration = configBuilder().build();
+    // THEN
+    then(recursiveComparisonConfiguration.getRepresentation()).isSameAs(STANDARD_REPRESENTATION);
+  }
+
   private static Builder configBuilder() {
     return RecursiveComparisonConfiguration.builder();
   }
