-
Notifications
You must be signed in to change notification settings - Fork 29
Comparing changes
Open a pull request
base repository: assert-rs/predicates-rs
base: v0.5.2
head repository: assert-rs/predicates-rs
compare: v0.9.0
- 16 commits
- 42 files changed
- 3 contributors
Commits on Jul 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a5a2dd4 - Browse repository at this point
Copy the full SHA a5a2dd4View commit details
Commits on Jul 27, 2018
-
Use T: ?Sized everywhere for FnPredicate so slices and str work
The implicit `T: Sized` bound on `FnPredicate` meant that function predicates could not be used with slices or `str`. Removing that bound by adding `T: ?Sized` to all the declarations makes this work.
Configuration menu - View commit details
-
Copy full SHA for 56592ba - Browse repository at this point
Copy the full SHA 56592baView commit details -
Merge pull request #63 from luser/function-unsized
Use T: ?Sized everywhere for FnPredicate so slices and str work
Configuration menu - View commit details
-
Copy full SHA for 53ef88a - Browse repository at this point
Copy the full SHA 53ef88aView commit details
Commits on Jul 28, 2018
-
Add imports and modify mod.rs, adapter.rs and normalize.rs
Resolve adapter.rs Added normalize_newlines adapter predicate Created normalize file and added normalize-line-endings as default dependency Created normalize trim predicate Fixes #45 Normalize newlines - Insert newline in adapter.rs for readability - Add example code in adapter.rs for usability - Add self to mod.rs - Change to NormalizedPredicate in normalize.rs to avoid ambiguity Normalize newlines syntax clean-up Make comments "///" instead of "//" for consistency Improve readability by making one commented block for function in adapter.rs Delete extraneous whitespace for readability Normalize NewLines Add copyright notice to adapters.rs and normalize.rs Amend doc tests for passing CI Normalize NewLines passes all tests Struct documentation added for NormalizedPredicate Assert tests fixed in adapters.rs (string assertions did not match) change struct description to pred.normalize() for consistency Add Cfg feature to NormalizedPredicate in adapter.rs
Configuration menu - View commit details
-
Copy full SHA for a418eef - Browse repository at this point
Copy the full SHA a418eefView commit details -
Merge pull request #61 from kammitama5/normalize_newlines
Normalize newlines
Configuration menu - View commit details
-
Copy full SHA for b4659e5 - Browse repository at this point
Copy the full SHA b4659e5View commit details -
Predicates can now report parameter details that don't show up in `Display` as well as what children they have. The expectation is that this will be used by the solution for #7. BREAKING CHANGE: `Predicate`s must also implement `reflection::PredicateReflection`.
Configuration menu - View commit details
-
Copy full SHA for b7d23e1 - Browse repository at this point
Copy the full SHA b7d23e1View commit details -
feat: Implement reflection for predicates
This also saw an audit of predicates to ensure their `Display` would most likely remain as one line of text. Anything in a `Display` that seemed likely to overflow was moved to a `Parameter`.
Configuration menu - View commit details
-
Copy full SHA for de153eb - Browse repository at this point
Copy the full SHA de153ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 940f320 - Browse repository at this point
Copy the full SHA 940f320View commit details -
feat: Extend Predicate to report cause
This is the last of the foundation for resolving #7.
Configuration menu - View commit details
-
Copy full SHA for 53e47ff - Browse repository at this point
Copy the full SHA 53e47ffView commit details -
feat: Implement
find_case
for predicatesA non-default implementation is provided for all predicates that can add additional information than what `eval` / `Display` provide. Exceptions - `eq_file`: I want to re-work this predicate - `BoxPredicate`: The where clause is causing problems This is the information needed for resolving #7. Now, rendering is the only thing left.
Configuration menu - View commit details
-
Copy full SHA for 200b8de - Browse repository at this point
Copy the full SHA 200b8deView commit details -
chore: Make
find_case
object safeApparently, a provided function can't downcast `&self` but I can if I spread the implementation around. Overall, trying to meet the goal of making it simple to write a Predicate. Anyone besides us will need to copy `default_find_case` if they want the reference. Not sure what would be a good way to make that good enough for being stable.
Configuration menu - View commit details
-
Copy full SHA for 1e92602 - Browse repository at this point
Copy the full SHA 1e92602View commit details -
feat: Tree view of Predicate result (Case)
Finnaly, Fixes #7. Inspired by the work in #39. Created softprops/treeline#3 for trying to find ways to make this more efficient.
Configuration menu - View commit details
-
Copy full SHA for 67085fc - Browse repository at this point
Copy the full SHA 67085fcView commit details -
Merge pull request #60 from epage/tree
A way to display *why* a predicate failed
Configuration menu - View commit details
-
Copy full SHA for cc1dab0 - Browse repository at this point
Copy the full SHA cc1dab0View commit details
Commits on Jul 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9ebb467 - Browse repository at this point
Copy the full SHA 9ebb467View commit details -
Merge pull request #64 from epage/split
feat: Decouple Predicate from implementations
Configuration menu - View commit details
-
Copy full SHA for 7a49e27 - Browse repository at this point
Copy the full SHA 7a49e27View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac3493d - Browse repository at this point
Copy the full SHA ac3493dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.5.2...v0.9.0