Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: assert-rs/predicates-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.2
Choose a base ref
...
head repository: assert-rs/predicates-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.0
Choose a head ref
  • 16 commits
  • 42 files changed
  • 3 contributors

Commits on Jul 24, 2018

  1. Copy the full SHA
    a5a2dd4 View commit details

Commits on Jul 27, 2018

  1. Use T: ?Sized everywhere for FnPredicate so slices and str work

    The implicit `T: Sized` bound on `FnPredicate` meant that function
    predicates could not be used with slices or `str`. Removing that bound
    by adding `T: ?Sized` to all the declarations makes this work.
    luser committed Jul 27, 2018
    Copy the full SHA
    56592ba View commit details
  2. Merge pull request #63 from luser/function-unsized

    Use T: ?Sized everywhere for FnPredicate so slices and str work
    epage authored Jul 27, 2018
    Copy the full SHA
    53ef88a View commit details

Commits on Jul 28, 2018

  1. Add imports and modify mod.rs, adapter.rs and normalize.rs

    Resolve adapter.rs
    
    Added normalize_newlines adapter predicate
    
    Created normalize file and added normalize-line-endings as default dependency
    Created normalize trim predicate
    Fixes #45
    
    Normalize newlines
    
    - Insert newline in adapter.rs for readability
    - Add example code in adapter.rs for usability
    - Add self to mod.rs
    - Change to NormalizedPredicate in normalize.rs to avoid ambiguity
    
    Normalize newlines syntax clean-up
    
    Make comments "///" instead of "//" for consistency
    Improve readability by making one commented block for function in adapter.rs
    Delete extraneous whitespace for readability
    
    Normalize NewLines
    
    Add copyright notice to adapters.rs and normalize.rs
    
    Amend doc tests for passing CI
    
    Normalize NewLines passes all tests
    
    Struct documentation added for NormalizedPredicate
    Assert tests fixed in adapters.rs (string assertions did not match)
    
    change struct description to pred.normalize() for consistency
    
    Add Cfg feature to NormalizedPredicate in adapter.rs
    kammitama5 committed Jul 28, 2018
    Copy the full SHA
    a418eef View commit details
  2. Merge pull request #61 from kammitama5/normalize_newlines

    Normalize newlines
    epage authored Jul 28, 2018
    Copy the full SHA
    b4659e5 View commit details
  3. feat: Add basic reflection

    Predicates can now report parameter details that don't show up in
    `Display` as well as what children they have.  The expectation is that
    this will be used by the solution for #7.
    
    BREAKING CHANGE: `Predicate`s must also implement
    `reflection::PredicateReflection`.
    epage committed Jul 28, 2018
    Copy the full SHA
    b7d23e1 View commit details
  4. feat: Implement reflection for predicates

    This also saw an audit of predicates to ensure their `Display` would
    most likely remain as one line of text.  Anything in a `Display` that
    seemed likely to overflow was moved to a `Parameter`.
    epage committed Jul 28, 2018
    Copy the full SHA
    de153eb View commit details
  5. 8728 norm full

    epage committed Jul 28, 2018
    Copy the full SHA
    940f320 View commit details
  6. feat: Extend Predicate to report cause

    This is the last of the foundation for resolving #7.
    epage committed Jul 28, 2018
    Copy the full SHA
    53e47ff View commit details
  7. feat: Implement find_case for predicates

    A non-default implementation is provided for all predicates that can add
    additional information than what `eval` / `Display` provide.
    
    Exceptions
    - `eq_file`: I want to re-work this predicate
    - `BoxPredicate`: The where clause is causing problems
    
    This is the information needed for resolving #7.  Now, rendering is the
    only thing left.
    epage committed Jul 28, 2018
    Copy the full SHA
    200b8de View commit details
  8. chore: Make find_case object safe

    Apparently, a provided function can't downcast `&self` but I can if I
    spread the implementation around.
    
    Overall, trying to meet the goal of making it simple to write a
    Predicate.  Anyone besides us will need to copy `default_find_case` if
    they want the reference.  Not sure what would be a good way to make that
    good enough for being stable.
    epage committed Jul 28, 2018
    Copy the full SHA
    1e92602 View commit details
  9. feat: Tree view of Predicate result (Case)

    Finnaly, Fixes #7.
    
    Inspired by the work in #39.
    
    Created softprops/treeline#3 for trying to find ways to make this more
    efficient.
    epage committed Jul 28, 2018
    Copy the full SHA
    67085fc View commit details
  10. Merge pull request #60 from epage/tree

    A way to display *why* a predicate failed
    epage authored Jul 28, 2018
    Copy the full SHA
    cc1dab0 View commit details

Commits on Jul 30, 2018

  1. feat: Decouple Predicate from implementations

    Fixes #30
    epage committed Jul 30, 2018
    Copy the full SHA
    9ebb467 View commit details
  2. Merge pull request #64 from epage/split

    feat: Decouple Predicate from implementations
    epage authored Jul 30, 2018
    Copy the full SHA
    7a49e27 View commit details
  3. chore(all): Release 0.9.0

    epage committed Jul 30, 2018
    Copy the full SHA
    ac3493d View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff v0.5.2...v0.9.0