This repository was archived by the owner on Dec 18, 2018. It is now read-only.
[WIP][2.2] Remove lock contention in IOQueue #3096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
changed the title
Member
|
This should be against 3.0 (master) |
Contributor
Author
Yeah, that's this one #3093 This is only to benchmark more easily on 2.2; which is why I've flagged it as [WIP] |
Member
|
I am not seeing any improvements on either pipelined or non-pipelined, windows or linux. Should it be an obvious win and my tests are wrong? |
Contributor
Author
|
K, thanks for trying. I was seeing the contention against .NET Core 3.0 (built from current source); so it may be since that is faster, contention comes more into play. Will keep the other PR open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing #3093
@sebastienros version for benchmarking; should effect pipelined, may effect non-pipelined