Skip to content

Conversation

@twsouthwick
Copy link
Contributor

No description provided.

@twsouthwick twsouthwick marked this pull request as ready for review March 29, 2022 01:32
@twsouthwick
Copy link
Contributor Author

After looking at framework's implementation of HttpCookieCollection again, it's actually just a collection that gets written at the end. I've updated this to do the same by hooking into the HttpResponse.OnStarting event.

I've also added a couple of endpoints that manipulate cookies and they do it the same now on framework and core.

This will not keep the worlds in-sync (i.e. cookies set by using the adapters with the cookies set using IResponseCookies). However, this is similar to ASP.NET framework where if you're working directly with the header, things wouldn't show up there either.

@twsouthwick twsouthwick requested a review from Tratcher March 29, 2022 21:22
@twsouthwick twsouthwick merged commit c26d673 into main Mar 29, 2022
@twsouthwick twsouthwick deleted the tasou/cookies branch March 29, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants