Implement HttpRequest against core. #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASP.NET framework had a fully buffered response stream that allowed things like clearing the response stream and setting a flag to not write things out. In order to enable that, a new IHttpResponseBodyFeature is inserted via middleware that will allow for that behavior.
Tratcher
reviewed
Mar 22, 2022
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Ross <[email protected]>
Co-authored-by: Chris Ross <[email protected]>
Tratcher
reviewed
Mar 23, 2022
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
src/SystemWebAdapters/src/Adapters/BufferedHttpResponseFeature.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Ross <[email protected]>
Co-authored-by: Chris Ross <[email protected]>
Closed
22 tasks
Tratcher
reviewed
Mar 24, 2022
| } | ||
| } | ||
|
|
||
| public void End() => Task.Run(async () => await CompleteAsync()).GetAwaiter().GetResult(); |
Member
There was a problem hiding this comment.
What does the Task.Run accomplish? You're still blocked waiting for it.
Contributor
Author
There was a problem hiding this comment.
That's the pattern I've seen recommended for sync over async. If it doesn't matter in asp.net core (since there's no synchronization context), I can just wait for it directly
Member
There was a problem hiding this comment.
It doesn't matter in core, wait directly.
Tratcher
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASP.NET framework had a fully buffered response stream that allowed things like clearing the response stream and setting a flag to not write things out. In order to enable that, a new IHttpResponseBodyFeature is inserted via middleware that will allow for that behavior.