TokenBucketRateLimiter implementation #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
davidfowl,
eerhardt,
halter73 and
shirhatti
BrennanConroy
commented
Oct 7, 2021
halter73
reviewed
Oct 14, 2021
halter73
reviewed
Oct 14, 2021
halter73
reviewed
Oct 14, 2021
halter73
reviewed
Oct 14, 2021
halter73
reviewed
Oct 14, 2021
| /// <summary> | ||
| /// <see cref="RateLimiter"/> implementation that replenishes tokens periodically instead of via a release mechanism. | ||
| /// </summary> | ||
| public sealed class TokenBucketRateLimiter : RateLimiter |
Member
There was a problem hiding this comment.
Should this be disposable because of the _renewTimer? Even if AutoReplenishment is disabled, we probably would want to cancel all queued acquisition request because I doubt anyone will be calling TryReplenish() after disposal and we'll want to cancel all the Tasks and dispose all the CancellationTokenRegistrations.
BrennanConroy
force-pushed
the
brecon/tokenlimiter
branch
from
a87be3c to
13b92c0
Compare
4 tasks
halter73
reviewed
Nov 11, 2021
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
Let's file an issue for making rate limiters disposable.
halter73
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #387 so there aren't two PRs adding the test infra/csproj properties.